Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic concepts: pipeline stages #1431

Closed
4 tasks done
jorgeorpinel opened this issue Jun 12, 2020 · 10 comments · Fixed by #1576
Closed
4 tasks done

basic concepts: pipeline stages #1431

jorgeorpinel opened this issue Jun 12, 2020 · 10 comments · Fixed by #1576
Labels
A: docs Area: user documentation (gatsby-theme-iterative) p1-important Active priorities to deal within next sprints website: eng-doc DEPRECATED JS engine for /doc

Comments

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Jun 12, 2020

Other than explaining what a pipeline stage is, this can help us group 2 terms that are used extensively and sometimes confusingly throughout docs: .dvc files (formerly DVC-files) and dvc.yaml — which already have their own guide so maybe this can just use that page instead of a new basic concepts one. Not sure

See more context: #1408 (comment):

Mentioning dvc.yaml and .dvc (everywhere) is too noisy

Automatic linking

Maybe should be a separate issue

Jump to #1431 (comment) for an update.

@jorgeorpinel jorgeorpinel added type: discussion Requires active participation to reach a conclusion. A: docs Area: user documentation (gatsby-theme-iterative) labels Jun 12, 2020
@jorgeorpinel jorgeorpinel changed the title basic concepts: pipeline stages basic concepts: pipeline stages + automatic link Jun 12, 2020
@jorgeorpinel jorgeorpinel added the p0-critical Affects users in a bad way at the moment label Jun 12, 2020
@shcheklein
Copy link
Member

@rogermparent let's start on this next, when you have time

@jorgeorpinel
Copy link
Contributor Author

Would be nice to decide on #1395 first too! I guess I should prioritize #550 to facilitate all this...

@rogermparent

This comment has been minimized.

@shcheklein

This comment has been minimized.

@rogermparent
Copy link
Contributor

That's a reasonable concern, I'll check if we have an existing Remark plugin that has that behavior and make a new one if we don't.

@shcheklein
Copy link
Member

@rogermparent yes, we do this already for dvc add kind of links, there should be code around for this.

@rogermparent
Copy link
Contributor

rogermparent commented Jul 14, 2020

From what I understand, there's three currently proposed entries for the automatic linker

  • dvc.yaml could be like a command name, which automatically links to its user guide
  • "orphan stage" we could link manually to dvc add
  • "import stage" to dvc import?

There's also

which I can do, but is notably separate from the rest and may need another Issue as Glossary entries need to wait for tooltip content where auto-linker entries have everything they need in the description.

I'll repost this in the PR thread as well, where it'll be easier to keep track of.

@jorgeorpinel jorgeorpinel changed the title basic concepts: pipeline stages + automatic link basic concepts: pipeline stages Jul 15, 2020
@jorgeorpinel jorgeorpinel removed the type: discussion Requires active participation to reach a conclusion. label Jul 15, 2020
@iterative iterative deleted a comment from rogermparent Jul 15, 2020
@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Jul 15, 2020

"orphan stage" we could link manually to dvc add

Don't worry about that one. We got rid of the term.

"import stage" to dvc import

We won't be using that term either in the future, just import .dvc file possibly. So probably also no special work needed there.

"stage" could have a tooltip and glossary entry.

That's the doc-content part of this issue. I guess it should be a separate issue, let's just leave it unchecked for now? And we also need:

remove all existing manual links from dvc.yaml, dvc.lock, and .dvc file.

@jorgeorpinel jorgeorpinel added website: eng-doc DEPRECATED JS engine for /doc p1-important Active priorities to deal within next sprints and removed p0-critical Affects users in a bad way at the moment labels Jul 15, 2020
@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Jul 15, 2020

Chnged to p1 since all the doc-engine work here has been done by @rogermparent from what I understand. Thanks Roger!!! BTE, I also added to the issue description (content related):

remove all existing manual links from dvc.yaml, dvc.lock, and .dvc file.

Is dvc.lock also auto-linked now? If not where do we add it? Thanks

@jorgeorpinel
Copy link
Contributor Author

"stage" could have a tooltip and glossary entry.
which I can do, but is notably separate

Extracted this to #1579 Roger, so that your PR closes this one 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) p1-important Active priorities to deal within next sprints website: eng-doc DEPRECATED JS engine for /doc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants