term: DVC-file -> .dvc file from Utkarsh work (2nd chunk) #1403
Conversation
Your trial has endedChoose a plan to resume monitoring your Sites and Pull Requests. If you need help, check the Manage Your Plan and Test Usage guide. |
| targets DVC-files to remove. | ||
| targets `.dvc` files to remove. |
There was a problem hiding this comment.
@efiop we need to do this same for the core repo when possible please. See iterative/dvc/issues/3960
There was a problem hiding this comment.
@jorgeorpinel Wait, that looks wrong. It should be "stages or .dvc files to remove". It works with dvc.yaml too.
There was a problem hiding this comment.
I was assuming remove only works with .dvc files like move. OK, great to know, so let's go with this:
| targets DVC-files to remove. | |
| targets `.dvc` files to remove. | |
| targets stages (found in `dvc.yaml`) or `.dvc` files to remove. |
There was a problem hiding this comment.
I was thinking of not to mention this yet, only after we release docs for run.
There was a problem hiding this comment.
remove only has --outs flag now, and 0.94's remove and 1.0's remove behavior are completely different.
There was a problem hiding this comment.
OK, good to know @skshetry . Please open a separate issue or PR from the core repo PR where remove is changed (usual process). This PR is about updating "DVC-file" terminology. Thanks
There was a problem hiding this comment.
@utkarshsingh99 OK here's the plan! I reviewed half of the files here so far. Please copy this branch to your fork and RE-OPEN the PR from there (so that you can contribute to it because you won't be able to commit here). Then address by review 👇 and ping me so we can continue it there.
I'll just close this draft PR when that happens. Thanks
|
A couple questions to Ruslan are still open but I'll close this now in favor of #1408 |
Actually just #1403 (review) now, and it's more of a comment/reminder, not a question. Abandoning this ship! ⚓ |
Cc @utkarshsingh99 sorry, I'm basically stealing your work a little here. Need to move things along and the git operations were a little complex.