-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DVC file -> .dvc file (2nd chunk) reopen #1408
Conversation
Your trial has endedChoose a plan to resume monitoring your Sites and Pull Requests. If you need help, check the Manage Your Plan and Test Usage guide. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Jorge Orpinel <[email protected]>
@jorgeorpinel Interestingly, the status page is not crashing anymore. I'm still not sure what the problem was, though. 😬 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as status is working now, it doesn't matter what the problem was 😬
Thanks again for this big one @utkarshsingh99 you have really helped us a lot! I'm approving this one but there's a couple things missing (below) which I will probably just commit myself.
@shcheklein may want to take a quick look before we merge this though.
@utkarshsingh99 @jorgeorpinel approved and merged but we should go back to whiteboard:
|
@jorgeorpinel |
Shoot... I will check this. The review ap was working fine last time I checked.
Totally agree. I just wanted to get most of the main docs updated as a first step. I think the solution will be to replace all these 2ble mentions with some other concept like probably just "stage" which links to basic concepts and explains it can be either in a dvc.file or a .dvc file (orphan/import stage)
Also agree. I think we could make them automatic like command names, at least for
|
So the review app doesn't exist anymore unfort. Heroku deletes everything at merge (https://dashboard.heroku.com/apps/dvc-landing-dvc-file-2-nl7s1r2) I see no build problems in our prod app https://dashboard.heroku.com/apps/dvc-org/activity @shcheklein |
For 1. and 2. I created #1431 |
Partially address #1366
Continuation of #1372
Final version of draft PR #1403
Contains review changes suggested by @jorgeorpinel in #1403
UPDATE: jump to: #1408 (comment)