Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dvc: introduce dvc params diff #3573

Merged
merged 5 commits into from
Apr 9, 2020
Merged

dvc: introduce dvc params diff #3573

merged 5 commits into from
Apr 9, 2020

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Apr 1, 2020

@dmpetrov Volunteered to provide docs for this with nice examples πŸ™

  • ❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

@efiop efiop changed the title dvc: introduce dvc params diff [WIP] dvc: introduce dvc params diff Apr 1, 2020
dvc/command/params.py Outdated Show resolved Hide resolved
dvc/repo/params/diff.py Outdated Show resolved Hide resolved
dvc/repo/params/show.py Outdated Show resolved Hide resolved
@efiop efiop force-pushed the 3528 branch 2 times, most recently from f7052bd to b29c3e2 Compare April 3, 2020 11:32
@efiop
Copy link
Contributor Author

efiop commented Apr 7, 2020

Issues:

angles:          
    - 2          
    - 3          
    - 100        
    - 3.2        
    - 36.2       
    - 3.2        
df3: [1, 3]      
train:           
    lr: 0.0042   
    layers: 10   
    dropout: 0.21
processing:      
    th: 0.98     
    bow: 7000    

diff for angles will be shown as angles.N where N is the number of the element that changed in the list. Need to treat them as lists. EDIT: fixed

And if you change train.lr to 0.0042, diff will show it as 0.004. These affect metrics diff too. EDIT: fixed.

@efiop efiop force-pushed the 3528 branch 3 times, most recently from 02b6c22 to 73cf495 Compare April 7, 2020 15:47
@efiop efiop changed the title [WIP] dvc: introduce dvc params diff dvc: introduce dvc params diff Apr 7, 2020
@efiop efiop requested a review from dmpetrov April 7, 2020 16:18
@efiop efiop changed the title dvc: introduce dvc params diff [WIP] dvc: introduce dvc params diff Apr 7, 2020
@Suor
Copy link
Contributor

Suor commented Apr 8, 2020

@efiop when do you expect this to be merged?

@efiop
Copy link
Contributor Author

efiop commented Apr 8, 2020

@Suor Need to implement support for targets (will do today) and get an approval from @dmpetrov . So maybe later today.

@efiop efiop force-pushed the 3528 branch 3 times, most recently from 26fd104 to 0b65eba Compare April 8, 2020 12:57
@efiop efiop changed the title [WIP] dvc: introduce dvc params diff dvc: introduce dvc params diff Apr 8, 2020
@efiop efiop force-pushed the 3528 branch 2 times, most recently from 9dbe43c to 10e6a5c Compare April 8, 2020 22:47
@efiop efiop force-pushed the 3528 branch 2 times, most recently from 9a47ea6 to b9f3697 Compare April 9, 2020 00:17
@efiop efiop force-pushed the 3528 branch 5 times, most recently from e237722 to 385f255 Compare April 9, 2020 01:49
@efiop
Copy link
Contributor Author

efiop commented Apr 9, 2020

Ok, got aproval from Dmitry. Merging.

@efiop efiop merged commit c1ac6bb into iterative:master Apr 9, 2020
@efiop efiop deleted the 3528 branch April 9, 2020 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants