-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packaging nnunet for inference #40
Conversation
Thanks! 💯 Tested and worked well! The commands I used: single image
For this specific subject ( dataset
Total time elapsed: 291.84 seconds |
Just an idea - since the script is actually universal, we could consider moving it to ivadomed/data-conversion (but we would need to rename the repo again since |
That's a great idea! Could you please open an issue in the data-conversion repository so that others might have an opinion too? |
👍🏻 I reopened the issue ivadomed/utilities#9 discussing the repo name. |
Okay, the repo has been renamed (ivadomed/utilities#9 (comment)) to ivadomed/utilities. I guess we can push the script there. |
Tested (#40 (comment)) and working fine! I guess we can close this PR and move the script to https://github.com/ivadomed/utilities. |
Done in ivadomed/utilities@1d8112f. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to also have a section in the README to make it easier for people to run the inference, as done here: https://github.com/ivadomed/model_seg_ms_mp2rage#segment-an-image and here: https://github.com/ivadomed/model_seg_mouse-sc_wm-gm_t1#run-inference
Thank you @jcohenadad for the suggestion! It has been added in commit 7fbb42e |
Merging as reviewed in a meeting with @valosekj ! |
This PR adds a script for running inference using nnUNet. Currently, the script is tested on
joplin
with CPUs only. The inference on 1 Zurich subject takes about 30s on average.