Code Improvements #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Sigmanificient, thank you so much for taking the time to implement these code improvements. Given that Ivy is currently in a relatively turbulent phase and undergoing significant changes on a regular basis, we decided not to integrate these changes yet. However, we agree that implementing some basic pep8 rules would lead to better readability, and we'll get this improved in the near future, with your help of your PR! |
Closed
MrZilinXiao
referenced
this pull request
in MrZilinXiao/ivy
Aug 26, 2022
bsovdat
added a commit
to bsovdat/ivy
that referenced
this pull request
Sep 1, 2022
resolving issues ivy-llc#1
Closed
RickSanchezStoic
added a commit
that referenced
this pull request
Sep 20, 2022
* inital changes * changes * changes * changes * changes * changes * fix formatting for test_modules * changes * fix some formatting errors for our new tests * added docstrings for most but not all methods * add basic docstring outlines for all functions in module.py, need descriptions for functions, arguments and retursn * docstring add #1 (Need discussion) and (TODO) flags added for further discussion * add docstring #2 * add separation of positional-only arguments and keyword-only arguments * fix syntax error of module.py * changes and fixes * fixes * lint fixes * changes * changes * changes * changes; * conftest update deadline * changes made as requested * changes: Co-authored-by: Rishabh Kumar <[email protected]> Co-authored-by: Daniel4078 <[email protected]> Co-authored-by: Zilin Xiao <[email protected]>
Aaa2275
referenced
this pull request
in Aaa2275/ivy
Dec 2, 2022
Closed
This was referenced Mar 30, 2023
MuhammedAshraf2020
pushed a commit
to MuhammedAshraf2020/ivy
that referenced
this pull request
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I come across your repository, and i thought i could help to improve the code quality by implementing some basic pep8 rules, leading to a better readability.
I Also changed some structure to integrate list/dictionary comprehensions in order to have a more pythonic and simplified code.