Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EHN: ACOSH added in paddle.tensor.tensor.Tensor class from acosh #16007form list of function #15115 #16040

Merged
merged 50 commits into from
Jul 6, 2023
Merged

EHN: ACOSH added in paddle.tensor.tensor.Tensor class from acosh #16007form list of function #15115 #16040

merged 50 commits into from
Jul 6, 2023

Conversation

MuhammadNizamani
Copy link
Contributor

@MuhammadNizamani MuhammadNizamani commented May 30, 2023 •
edited
Loading

I have added acosh in Tensor class. Closed #16007

@MuhammadNizamani MuhammadNizamani mentioned this pull request May 30, 2023
Merged
@MuhammadNizamani MuhammadNizamani changed the title EHN: ACOSH added in paddle.tensor.tensor.Tensor class from acosh #16007 and form list of function #15115 EHN: ACOSH added in paddle.tensor.tensor.Tensor class from acosh #16007form list of function #15115 Jun 1, 2023
@MuhammadNizamani
Copy link
Contributor Author

@RickSanchezStoic I manually resolved the merge conflicts on GitHub, which is why the pre-commit check failed.

@RickSanchezStoic
Copy link
Contributor

@MuhammadNizamani Can you try resolving the merge conflicts? Otherwise looks good to me.

@RickSanchezStoic
Copy link
Contributor

@RashulChutani The tests don't seem to be picking up, can you confirm once?

@MuhammadNizamani
Copy link
Contributor Author

@RickSanchezStoic I think it was marge conflict and i have resolveed it

@RickSanchezStoic
Copy link
Contributor

@RashulChutani It's still not picking up tests, even after resolving merge conflicts, please have a look. Thanks!

@MuhammadNizamani
Copy link
Contributor Author

@RickSanchezStoic which tests you are talking about?

@RickSanchezStoic
Copy link
Contributor

RickSanchezStoic commented Jun 14, 2023 •
edited
Loading

@RickSanchezStoic which tests you are talking about?

intelligent-tests-pr / run_tests (1) (pull_request) this is where your test is supposed to be executed.

@MuhammadNizamani
Copy link
Contributor Author

@RickSanchezStoic it's been mounth could please review this

@MuhammadNizamani
Copy link
Contributor Author

@RickSanchezStoic review this please

@RickSanchezStoic
Copy link
Contributor

@RashulChutani will they need to create a new pr because the tests still don't seem to be picking up ?

fnhirwa
fnhirwa suggested changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@fnhirwa fnhirwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MuhammadNizamani
Would you resolve the merge conflicts for CI run

@MuhammadNizamani
Copy link
Contributor Author

@hirwa-nshuti I have resolve the merge conflict

@fnhirwa fnhirwa self-requested a review July 6, 2023 10:43
fnhirwa
fnhirwa approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@fnhirwa fnhirwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me😊
Going to merge

@fnhirwa fnhirwa merged commit ff0751d into ivy-llc:master Jul 6, 2023
@MuhammadNizamani MuhammadNizamani deleted the acosh branch July 6, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnhirwa fnhirwa fnhirwa approved these changes

Assignees

@RickSanchezStoic RickSanchezStoic

Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

acosh
5 participants
@MuhammadNizamani @RickSanchezStoic @RashulChutani @fnhirwa @ivy-leaves