Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EHN: asin added in paddle.tensor.tensor.Tensor class, from issue asin #16043 and form list of function #15115 #16046

Merged
merged 7 commits into from
Jun 1, 2023

Conversation

MuhammadNizamani
Copy link
Contributor

@MuhammadNizamani MuhammadNizamani commented May 30, 2023

I have added asin function it might conflict with PR #16040
#16043

@soma2000-lang
Copy link
Contributor

soma2000-lang commented Jun 1, 2023

@MuhammadNizamani I think it would be unsupported dtypes.Line no 101

@MuhammadNizamani
Copy link
Contributor Author

@soma2000-lang I was bit confuse about it so I checked file paddle.tensor.tensor.math.py it has same method and it was using supported so I followed it because it was marge in main branch. Can you explain why it should unsupported in paddle.tensor.tensor.Tensor but not in paddle.tensor.tensor.Tensor?
Thanks for review.

@MuhammadNizamani
Copy link
Contributor Author

@soma2000-lang I will modify this to unsupported dtypes. just so know sqrt, log_softmax and asin these are the method that uses supported in paddle.tensor.tensor.math.py.

@soma2000-lang
Copy link
Contributor

@MuhammadNizamani thanks for pointing out .After digging into this I found out that it will be supported only.I will be merging this.
Thanks for contributing😊

@soma2000-lang soma2000-lang merged commit 72fcdd7 into ivy-llc:master Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants