-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recursively scan parent POMs for license #23
Conversation
Sorry, the second commit shouldn't be part of this pull request. But now that it's done, feel free which commits you want to merge :) A few words about the second commit: I though it would make sense to include all licenses of a library instead of just the first one. This means that this is now an array inside the generated json. The same is true for the "developers", which are now an array instead of a concatenated string. The json now also contains the description and version of the library, because the license can change with new versions. The "url" of the library is now extracted from All changes of the second commit only apply to the json report. The html report is exactly the same as before. |
@ChristianCiach So sorry! I never got a email about this. This is a great contribution, thank so much!
|
@ChristianCiach Let's update this PR real fast and merge in your feature. |
@ChristianCiach Here is the issue: #15. |
Thanks for the feedback! I probably can't work on this in the next days, but you can expect the proposed changes next week. Thanks for the tip with the git configuration. For this I probably need to close this pull request and open a new one. I will split the two commits to separate pull requests. Are you even interested to merge the second commit? I would appreciate it, because I wouldn't need to maintain a fork in this case. But please keep in mind that this would be a breaking change for existing users depending on the json report. |
You can close and create a new one or simply amend authorship: https://stackoverflow.com/a/3042512/950427. Both commits are great. I honestly do not care if they are in a separate PR or not. We just need to update the README. |
Alright, I am back and I will see what I can do :) |
@ChristianCiach Sounds good. |
Previously, only the direct parent POM was scanned for license information. In many cases, this is not sufficient.
This pull request changes this behavior so that all parent POMs are scanned recursively. In my case, this finds A LOT of licenses that weren't found before, like for various Apache-commons and Jetty libraries.