Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#28 Support multiple licenses; add more attributes to json #29

Merged
merged 3 commits into from
Jan 9, 2018

Conversation

ChristianCiach
Copy link
Contributor

References issue #28 and obsolete pull request #23.

@ChristianCiach
Copy link
Contributor Author

This pull request builds on top of pull request #27. I am curious how github handles this.

@jaredsburrows jaredsburrows merged commit ad61110 into jaredsburrows:master Jan 9, 2018
@jaredsburrows
Copy link
Owner

@ChristianCiach It looks like there are no merge conflicts, thank you so much! This should close #28.

@ChristianCiach
Copy link
Contributor Author

Thanks! The example license information in the JSON for the android-support-Design artifact (inside the README.md) is still pretty useless, but at least it contains a version number now ;)

Maybe it would make sense to include a predefined "url" to the Android-Support-Library website and Google as the "developer", just as the "license" is predefined for the group "com.android.support". I am not using this library with Android, so I don't care. It's just something I notices while updating the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants