-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WinDef.DWORD getLow() & getHigh() using incorrect bit mask #624
Comments
It would be useful to track down why/where it was reverted, otherwise needs a new PR and a test. |
The "where" is 4218a07 , the "why" is probably by accident. The commit changed the whitespace on the whole file, which drowned the fact these two lines got reverted. |
cc: @wolftobias |
I created a PR (#683) that reverts the problem and introduces a test, that should prevent breakage in the future. The failing unittest on mac os x fails building the native part, so that result is ignored, unittests on windows work correctly. If no veto is raised, the PR will be merged sometime next week. |
Motivation: A API was changed in quiche to address a bug. We need to adjust our code as well Modifications: Pass in a pointer for the sequence number Result: Compiles against latest quiche code
#128 was fixed by 245eb88 in 2012, but then 4218a07 reverted it with no explanation given. So I'm reopening it again.
Old bug description:
These two methods are using 0xFF as the bit mask when they should be using 0xFFFF. Each method returns a WORD, which is a 16-bit value. By using 0xFF only the lower byte is preserved.
New Code:
Old Code:
The text was updated successfully, but these errors were encountered: