Use correct bit masks when extracting low/high word from DWORD #683
+48
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a regression introduced by commit 4218a07 The applied bit masks a 8 bit value, while word is 16 bit sized. Closes: java-native-access#624
The desiredAccess value for OpenProcess was 0, this resulted in a access denied error. While OpenProcess does not document this, it mentions correct values, which do not include 0. As QueryFullProcessImageName is documented to require PROCESS_QUERY_INFORMATION or PROCESS_QUERY_LIMITED_INFORMATION. As PROCESS_QUERY_LIMITED_INFORMATION is documented to be wider supported this is choosen. https://msdn.microsoft.com/de-de/library/windows/desktop/ms684880(v=vs.85).aspx
mstyura
pushed a commit
to mstyura/jna
that referenced
this pull request
Sep 9, 2024
java-native-access#683) …s received Motivation: If STREAM_STOPPED is received we should fail all writes with ChannelOutputShutdownException before tearing down the channel Modifications: Explicit handle STREAM_STOPPED Result: Better signaling of received STREAM_STOPPED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.