Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to omit footer from the output of pip-compile #276

Closed
wants to merge 1 commit into from

Conversation

jonafato
Copy link
Contributor

When compiling requirements, the commented unsafe packages can create
noise. setuptools, for example, is updated frequently. The proposed
no-footer option allows suppression of these comments (e.g. to
reduce noise in source control diffs or simply because a user may not
care about those packages).

The option is called --no-footer to match the existing
--no-header option.

When compiling requirements, the commented unsafe packages can create
noise. setuptools, for example, is updated frequently. The proposed
``no-footer`` option allows suppression of these comments (e.g. to
reduce noise in source control diffs or simply because a user may not
care about those packages).

The option is called ``--no-footer`` to match the existing
``--no-header`` option.
@nvie
Copy link
Member

nvie commented Jan 14, 2016

The idea behaviour here:

  • Don't name option --footer. It's not necessarily a footer. I just happened to have grouped them there for convenience.
  • The real noise is caused by version changes in these comment lines. I'm fine removing the version spec for these lines from the output. Basically, it'd just say that "setuptools" is ignored.

This way, we'd solve the problem of those lines not remaining stable over time and causing noise (which I agree is a good idea), but we don't introduce an extra flag.

What do you think, @jonafato? Could you change this PR to reflect that?

@jonafato
Copy link
Contributor Author

@nvie Thanks for the feedback. You're right that this pull request added a lot more than it needed to address the core issue I was having. Because the changes are so different, I'm closing this PR in favor of a new one created at #294.

@jonafato jonafato closed this Jan 15, 2016
@jonafato jonafato deleted the no-footer-option branch January 15, 2016 18:45
jonafato added a commit to jonafato/pip-tools that referenced this pull request Jan 15, 2016
As discussed in jazzband#276, version specifiers for unsafe requirements create
noise in diffs. This change omits versions from those requirements, so
the noise is silenced.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants