Remove specifiers for unsafe requirements #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Much better this way! |
|
Can't merge this now (I'm on mobile). Will merge when I'm on a desktop machine. |
As discussed in jazzband#276, version specifiers for unsafe requirements create noise in diffs. This change omits versions from those requirements, so the noise is silenced.
jonafato
force-pushed
the
remove-unsafe-versions
branch
from
4dff871
to
dba4cae
Compare
|
@nvie: Rebased against master. |
nvie
added a commit
that referenced
this pull request
Jan 15, 2016
Remove specifiers for unsafe requirements
|
Thanks! |
This was referenced Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #276, version specifiers for unsafe requirements create
noise in diffs. This change omits versions from those requirements, so
the noise is silenced.