Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links with parenthesis mess up syntax highlighting #35

Open
Qix- opened this issue Jul 29, 2015 · 4 comments
Open

Links with parenthesis mess up syntax highlighting #35

Qix- opened this issue Jul 29, 2015 · 4 comments

Comments

@Qix-
Copy link

Qix- commented Jul 29, 2015

[some link](https://en.wikipedia.org/wiki/Tree_(data_structure)#Terminologies_used_in_Trees)

parses and is displayed correctly in live preview, but the syntax highlighting is incorrect.

screen shot 2015-07-28 at 6 48 35 pm

@jbt
Copy link
Owner

jbt commented Jul 29, 2015

This'll be an issue with CodeMirror's markdown mode. Looks like it's been updated upstream since I last grabbed it so I'll see about updating it and that may sort this.

That said, I really should round off and merge #25 which ditches CodeMirror entirely and would make things nicer to work with

@jbt
Copy link
Owner

jbt commented Jul 29, 2015

Well I bumped to latest and that doesn't seem to have fixed it. I'll have a little dig around and see if it's feasible to try and figure out the necessary changes in codemirror or whether it'd be less effort to finish off that PR

@Qix-
Copy link
Author

Qix- commented Jul 29, 2015

👍 for prism. Does it properly handle the case I mentioned?

@jbt
Copy link
Owner

jbt commented Jul 30, 2015

Yup, you can check out that version here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants