Replace CodeMirror + Highlight with Prism + mdEdit #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: index.html
|
@jbt so mdEdit/Prism is going to be the future of this project? Should I still go with the CodeMirror one? I need an embeddable markdown editor (better with image paste/drop in support) in my project. I went through a couple of solutions and find yours is the most promising one. While I reach this pull request, I am sure if I should wait for the merge or the merge is not going to happen is the recent future |
|
Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes CodeMirror and Highlight and replaces them with mdEdit, a syntax-highlighted, semi-formatted markdown editor I've been working on, based on Prism.
This means much nicer and more consistent styling of code highlighting, consistent with fenced code blocks, and hopefully less buggy than CodeMirror's GFM implementation.
It also means it should be much easier to include support for things like YAML front-matter or markdown extensions (footnotes, superscript, subscript etc) without confusing the editor view's syntax highlighting.