Fix specs to be compatible with forked repositories #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests were coupled to a specific origin meaning that tests against forks would fail. I’ve replaced the test that checks the output of `git_remote_url` is okay into a test to check `git_remotes` returns something, and another to check that `git_remote_url` correctly interprets the output from `git_remotes`. I’ve also corrected the test doubles in later tests where (as part of jekyll#147) I had copied an incorrect bit of stubbing of `git_remote_url`. The stubbing appeared to be mimicking `git_remotes` instead. The test seemed to be passing by coincidence before. The stubbed output now matches what the function actually does.
|
@mrmanc Can you please explain why you made all those whitespace changes..? |
|
Yikes—I didn’t spot that I’d accidentally triggered my IDE’s reformatting functionality. That should be resolved now. |
|
The diff looks a lot better now. Thanks P.S. Ignore the failing tests in this context |
mrmanc
changed the title
Oh, not sure what the convention is. I’ve made it more descriptive based on looking at some closed PR titles. Any better? |
ashmaroli
changed the title
|
Don't worry about it. I've renamed it. |
parkr
approved these changes
Jan 5, 2019
|
@jekyllbot: merge +dev |
|
Thank you so much!! |
|
You’re welcome, I’ve enjoyed these contributions 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were coupled to a specific origin meaning that tests against forks would fail. I’ve replaced the test that checks the output of
git_remote_urlis okay into a test to checkgit_remotesreturns something, and another to check thatgit_remote_urlcorrectly interprets the output fromgit_remotes.I’ve also corrected the test doubles in later tests where (as part of #147) I had copied an incorrect bit of stubbing of
git_remote_url. The stubbing appeared to be mimickinggit_remotesinstead. The test seemed to be passing by coincidence before. The stubbed output now matches what the function actually does.