Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix specs to be compatible with forked repositories #152

Merged
merged 2 commits into from
Jan 5, 2019
Merged

Fix specs to be compatible with forked repositories #152

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b39b85
Fix #148 by stubbing git remote
mrmanc Jan 4, 2019
a639ceb
Remove accidental whitespace changes
mrmanc Jan 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions spec/repository_finder_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,17 @@
end

it "retrieves the git remote" do
expect(subject.send(:git_remotes)).not_to be_empty
end

it "extracts the origin from remotes returned by git" do
allow(subject).to receive(:git_remotes).and_return([
"origin\thttps://github.com/jekyll/github-metadata.git (fetch)",
"origin\thttps://github.com/jekyll/github-metadata.git (push)"
])
allow(subject).to receive(:git_remote_url).and_call_original
expect(subject.send(:git_remote_url)).to include("jekyll/github-metadata")

expect(subject.send(:git_remote_url)).to eql("https://github.com/jekyll/github-metadata.git")
end

{
Expand Down Expand Up @@ -69,20 +78,16 @@
after(:each) { ENV["JEKYLL_ENV"] = "test" }

it "handles periods in repo names" do
allow(subject).to receive(:git_remote_url).and_return <<-EOS
origin https://github.com/afeld/hackerhours.org.git (fetch)
origin https://github.com/afeld/hackerhours.org.git (push)
EOS
expect(subject.send(:nwo_from_git_origin_remote)).to include("afeld/hackerhours.org")
allow(subject).to receive(:git_remote_url).and_return "https://github.com/afeld/hackerhours.org.git"

expect(subject.send(:nwo_from_git_origin_remote)).to eql("afeld/hackerhours.org")
end

it "handles private github instance addresses" do
allow(Jekyll::GitHubMetadata::Pages).to receive(:github_hostname).and_return "github.myorg.com"
allow(subject).to receive(:git_remote_url).and_return <<-EOS
origin https://github.myorg.com/myorg/myrepo.git (fetch)
origin https://github.myorg.com/myorg/myrepo.git (push)
EOS
expect(subject.send(:nwo_from_git_origin_remote)).to include("myorg/myrepo")
allow(subject).to receive(:git_remote_url).and_return "https://github.myorg.com/myorg/myrepo.git"

expect(subject.send(:nwo_from_git_origin_remote)).to eql("myorg/myrepo")
end

context "when git doesn't exist" do
Expand Down