Merge pull request #5734 from prsantos-com/sonarcloud-promise-rejection

Use Error instead of literal for promise rejection
jellyfin · Jul 26, 2024 · b9dea3a · b9dea3a
2 parents 08bbcb0 + c3ad26e
commit b9dea3a
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 7 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -79,6 +79,7 @@ module.exports = {
         'operator-linebreak': ['error', 'before', { overrides: { '?': 'after', ':': 'after', '=': 'after' } }],
         'padded-blocks': ['error', 'never'],
         'prefer-const': ['error', { 'destructuring': 'all' }],
+        'prefer-promise-reject-errors': ['warn', { 'allowEmptyReject': true }],
         '@typescript-eslint/prefer-for-of': ['error'],
         '@typescript-eslint/prefer-optional-chain': ['error'],
         'quotes': ['error', 'single', { 'avoidEscape': true, 'allowTemplateLiterals': false }],

diff --git a/src/components/actionSheet/actionSheet.ts b/src/components/actionSheet/actionSheet.ts
@@ -366,7 +366,7 @@ export function show(options: Options) {
 
                     resolve(selectedId);
                 } else {
-                    reject('ActionSheet closed without resolving');
+                    reject(new Error('ActionSheet closed without resolving'));
                 }
             }
         });

diff --git a/src/components/playback/playbackmanager.js b/src/components/playback/playbackmanager.js
@@ -2502,7 +2502,7 @@ class PlaybackManager {
             return Promise.resolve()
                 .then(() => {
                     if (!isServerItem(item) || itemHelper.isLocalItem(item)) {
-                        return Promise.reject('skip bitrate detection');
+                        return Promise.reject(new Error('skip bitrate detection'));
                     }
 
                     return apiClient.getEndpointInfo()
@@ -2514,7 +2514,7 @@ class PlaybackManager {
                                 });
                             }
 
-                            return Promise.reject('skip bitrate detection');
+                            return Promise.reject(new Error('skip bitrate detection'));
                         });
                 })
                 .catch(() => getSavedMaxStreamingBitrate(apiClient, mediaType));

diff --git a/src/components/router/appRouter.js b/src/components/router/appRouter.js
@@ -389,7 +389,7 @@ class AppRouter {
             if (firstResult.State === ConnectionState.ServerSignIn) {
                 const url = firstResult.ApiClient.serverAddress() + '/System/Info/Public';
                 fetch(url).then(response => {
-                    if (!response.ok) return Promise.reject('fetch failed');
+                    if (!response.ok) return Promise.reject(new Error('fetch failed'));
                     return response.json();
                 }).then(data => {
                     if (data !== null && data.StartupWizardCompleted === false) {

diff --git a/src/plugins/syncPlay/core/Helper.js b/src/plugins/syncPlay/core/Helper.js
@@ -26,7 +26,7 @@ export function waitForEventOnce(emitter, eventType, timeout, rejectEventTypes)
         let rejectTimeout;
         if (timeout) {
             rejectTimeout = setTimeout(() => {
-                reject('Timed out.');
+                reject(new Error('Timed out.'));
             }, timeout);
         }
 

diff --git a/src/plugins/syncPlay/core/QueueCore.js b/src/plugins/syncPlay/core/QueueCore.js
@@ -123,7 +123,7 @@ class QueueCore {
 
         if (!itemIds.length) {
             if (this.lastPlayQueueUpdate && playQueueUpdate.LastUpdate.getTime() <= this.getLastUpdateTime()) {
-                return Promise.reject('Trying to apply old update');
+                return Promise.reject(new Error('Trying to apply old update'));
             }
 
             this.lastPlayQueueUpdate = playQueueUpdate;

diff --git a/src/plugins/syncPlay/core/timeSync/TimeSync.js b/src/plugins/syncPlay/core/timeSync/TimeSync.js
@@ -113,7 +113,7 @@ class TimeSync {
      */
     requestPing() {
         console.warn('SyncPlay TimeSync requestPing: override this method!');
-        return Promise.reject('Not implemented.');
+        return Promise.reject(new Error('Not implemented.'));
     }
 
     /**