Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Error instead of literal for promise rejection #5734

Merged

Conversation

prsantos-com
Copy link
Contributor

Changes

  • Replaced literal with an instance of the Error class in promise rejection where applicable.
  • Added the eslint rule prefer-promise-reject-errors to prevent this type of issue in the future. I set it to warn instead of error, as there was one promise rejection that used an object instead of a literal and fixing that would mean creating a custom error, which I feel is beyond the scope of this change.

Issues

None.

@prsantos-com prsantos-com requested a review from a team as a code owner June 26, 2024 02:51
@thornbill thornbill added the cleanup Cleanup of legacy code or code smells label Jul 11, 2024
@thornbill thornbill added this to the v10.10.0 milestone Jul 26, 2024
@thornbill thornbill merged commit b9dea3a into jellyfin:master Jul 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Cleanup of legacy code or code smells
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants