-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Descriptors for all parsers #548
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is exactly the right way! Some minor comments, but the general concept is 👍
src/main/java/edu/hm/hafner/analysis/descriptor/Descriptor.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/hm/hafner/analysis/descriptor/Descriptor.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/hm/hafner/analysis/descriptor/Descriptor.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/hm/hafner/analysis/descriptor/AcuCobolDescriptor.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/hm/hafner/analysis/descriptor/AcuCobolDescriptor.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #548 +/- ##
=========================================
Coverage ? 87.28%
Complexity ? 1593
=========================================
Files ? 258
Lines ? 5103
Branches ? 545
=========================================
Hits ? 4454
Misses ? 474
Partials ? 175
Continue to review full report at Codecov.
|
Superseded by #572 |
I merged your changes into a new branch targeting an upcoming release 10.0.0. I already integrated the new library API in my autograding action, works like a charm 🎉 In a next step I'll apply those changes in the warnings plugin. I needed to change the API slightly, does that still work for you? Keys of the parser are now the actual IDs and not the names. I also integrated the descriptions for some of the analysis tools (CheckStyle, SpotBugs, and PMD). |
Perfect, thank you very much! Do you have an idea when 10.0.0 will be released? |
You can always grab the latest release from https://repo.jenkins-ci.org/incrementals/edu/hm/hafner/analysis-model/ (if the build of my PR succeeds). Currently the latest release candidate is You can get it automatically in maven by adding the following snippet to the pom (see autograding-github-action/pom.xml and the corresponding Java class AutoGradingAction): <repositories>
<repository>
<id>repo.jenkins-ci.org</id>
<url>https://repo.jenkins-ci.org/public/</url>
</repository>
<repository>
<id>incrementals.jenkins-ci.org</id>
<url>https://repo.jenkins-ci.org/incrementals/</url>
</repository>
</repositories> I would still like to see how this new API works in the warnings plugin before doing a non-revertible release. Maybe it makes sense that we discuss that in Zoom? |
A Zoom call sounds like a good idea. |
No description provided.