Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Descriptors for all parsers #548

Closed
wants to merge 12 commits into from

Conversation

LorMun
Copy link
Contributor

@LorMun LorMun commented Dec 30, 2020

No description provided.

@LorMun LorMun changed the title WIP: added the first few descriptors and the factory class WIP: Descriptors for all parsers Dec 30, 2020
Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly the right way! Some minor comments, but the general concept is 👍

@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@dcb56f6). Click here to learn what that means.
The diff coverage is 82.88%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #548   +/-   ##
=========================================
  Coverage          ?   87.28%           
  Complexity        ?     1593           
=========================================
  Files             ?      258           
  Lines             ?     5103           
  Branches          ?      545           
=========================================
  Hits              ?     4454           
  Misses            ?      474           
  Partials          ?      175           
Impacted Files Coverage Δ Complexity Δ
...c/main/java/edu/hm/hafner/analysis/Categories.java 100.00% <ø> (ø) 5.00 <0.00> (?)
...va/edu/hm/hafner/analysis/FullTextFingerprint.java 89.47% <ø> (ø) 15.00 <0.00> (?)
.../java/edu/hm/hafner/analysis/RegexpLineParser.java 83.33% <ø> (ø) 4.00 <0.00> (?)
...hafner/analysis/descriptor/AcuCobolDescriptor.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...u/hm/hafner/analysis/descriptor/AjcDescriptor.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ner/analysis/descriptor/AndroidLintDescriptor.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ner/analysis/descriptor/AnsibleLintDescriptor.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...hafner/analysis/descriptor/AntJavacDescriptor.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../analysis/descriptor/Armcc5CompilerDescriptor.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...r/analysis/descriptor/ArmccCompilerDescriptor.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
... and 204 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcb56f6...4825b22. Read the comment docs.

@LorMun LorMun marked this pull request as ready for review February 1, 2021 14:44
@LorMun LorMun changed the title WIP: Descriptors for all parsers Descriptors for all parsers Feb 3, 2021
@uhafner uhafner added enhancement Enhancement of existing functionality removed labels Feb 15, 2021
@uhafner
Copy link
Member

uhafner commented Mar 1, 2021

Superseded by #572

@uhafner uhafner closed this Mar 1, 2021
@uhafner
Copy link
Member

uhafner commented Mar 1, 2021

I merged your changes into a new branch targeting an upcoming release 10.0.0. I already integrated the new library API in my autograding action, works like a charm 🎉 In a next step I'll apply those changes in the warnings plugin.

I needed to change the API slightly, does that still work for you? Keys of the parser are now the actual IDs and not the names. I also integrated the descriptions for some of the analysis tools (CheckStyle, SpotBugs, and PMD).

@LorMun
Copy link
Contributor Author

LorMun commented Mar 6, 2021

Perfect, thank you very much!
From what I've seen there is will be no problem with the changed API for me.

Do you have an idea when 10.0.0 will be released?

@uhafner
Copy link
Member

uhafner commented Mar 6, 2021

You can always grab the latest release from https://repo.jenkins-ci.org/incrementals/edu/hm/hafner/analysis-model/ (if the build of my PR succeeds). Currently the latest release candidate is 10.0.0-rc3952.178341475878.

You can get it automatically in maven by adding the following snippet to the pom (see autograding-github-action/pom.xml and the corresponding Java class AutoGradingAction):

  <repositories>
    <repository>
      <id>repo.jenkins-ci.org</id>
      <url>https://repo.jenkins-ci.org/public/</url>
    </repository>
    <repository>
      <id>incrementals.jenkins-ci.org</id>
      <url>https://repo.jenkins-ci.org/incrementals/</url>
    </repository>
  </repositories>

I would still like to see how this new API works in the warnings plugin before doing a non-revertible release. Maybe it makes sense that we discuss that in Zoom?

@LorMun
Copy link
Contributor Author

LorMun commented Mar 9, 2021

A Zoom call sounds like a good idea.
I'm pretty packed this week. Does next week suit you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants