Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptors for the parsers and a factory #572

Merged
merged 47 commits into from
Mar 19, 2021

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Feb 23, 2021

Add a registry for all parsers: parsers can be selected using an ID and the registry returns a parser descriptor that provides properties like URL, icon, help, default pattern and a factory method to create the actual parser.

This functionality previously was part of Jenkins' warnings plugin but it makes more sense to move it here so that other depending modules can reuse that part as well.

@uhafner uhafner added feature New features removed labels Feb 23, 2021
@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #572 (33979d8) into master (0c38e00) will increase coverage by 1.01%.
The diff coverage is 96.45%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #572      +/-   ##
============================================
+ Coverage     90.44%   91.45%   +1.01%     
- Complexity     1594     1979     +385     
============================================
  Files           178      303     +125     
  Lines          4927     5641     +714     
  Branches        548      571      +23     
============================================
+ Hits           4456     5159     +703     
- Misses          293      297       +4     
- Partials        178      185       +7     
Impacted Files Coverage Δ Complexity Δ
.../edu/hm/hafner/analysis/parser/AcuCobolParser.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
...u/hm/hafner/analysis/parser/AnsibleLintParser.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
.../edu/hm/hafner/analysis/parser/AntJavacParser.java 100.00% <ø> (ø) 14.00 <0.00> (ø)
...m/hafner/analysis/parser/Armcc5CompilerParser.java 100.00% <ø> (ø) 4.00 <0.00> (ø)
...hm/hafner/analysis/parser/ArmccCompilerParser.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
...u/hm/hafner/analysis/parser/BuckminsterParser.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
.../hafner/analysis/parser/CadenceIncisiveParser.java 70.00% <ø> (ø) 4.00 <0.00> (ø)
...ava/edu/hm/hafner/analysis/parser/ClangParser.java 100.00% <ø> (ø) 6.00 <0.00> (ø)
...edu/hm/hafner/analysis/parser/ClangTidyParser.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
.../hm/hafner/analysis/parser/CodeAnalysisParser.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
... and 302 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c38e00...33979d8. Read the comment docs.

@uhafner uhafner removed the removed label Mar 6, 2021
uhafner added a commit to jenkinsci/warnings-ng-plugin that referenced this pull request Mar 9, 2021
In analysis-model a new registry has been added in jenkinsci/analysis-model#572.
- parsers can be selected using an ID
- registry returns a parser descriptor that provides properties like URL, icon, help, default pattern
- registry contains a factory method to create the actual parser.

This functionality previously was part of Jenkins' warnings plugin but it makes more sense to move it
to the analysis-model so that other depending modules can reuse that part as well.
uhafner added a commit to jenkinsci/warnings-ng-plugin that referenced this pull request Mar 10, 2021
In analysis-model a new registry has been added in jenkinsci/analysis-model#572.
- parsers can be selected using an ID
- registry returns a parser descriptor that provides properties like URL, icon, help, default pattern
- registry contains a factory method to create the actual parser.

This functionality previously was part of Jenkins' warnings plugin but it makes more sense to move it
to the analysis-model so that other depending modules can reuse that part as well.
@uhafner uhafner marked this pull request as ready for review March 19, 2021 17:37
@uhafner uhafner merged commit d0c609f into master Mar 19, 2021
@uhafner uhafner deleted the hide-parsers-and-provide-registry branch March 19, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants