Add descriptors for the parsers and a factory #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #572 +/- ##
============================================
+ Coverage 90.44% 91.45% +1.01%
- Complexity 1594 1979 +385
============================================
Files 178 303 +125
Lines 4927 5641 +714
Branches 548 571 +23
============================================
+ Hits 4456 5159 +703
- Misses 293 297 +4
- Partials 178 185 +7
Continue to review full report at Codecov.
|
Rename factory to `ParserRegistry`. Map entries by ID and not by name.
…ovide-registry # Conflicts: # pom.xml
uhafner
added a commit
to jenkinsci/warnings-ng-plugin
that referenced
this pull request
Mar 9, 2021
In analysis-model a new registry has been added in jenkinsci/analysis-model#572. - parsers can be selected using an ID - registry returns a parser descriptor that provides properties like URL, icon, help, default pattern - registry contains a factory method to create the actual parser. This functionality previously was part of Jenkins' warnings plugin but it makes more sense to move it to the analysis-model so that other depending modules can reuse that part as well.
uhafner
added a commit
to jenkinsci/warnings-ng-plugin
that referenced
this pull request
Mar 10, 2021
In analysis-model a new registry has been added in jenkinsci/analysis-model#572. - parsers can be selected using an ID - registry returns a parser descriptor that provides properties like URL, icon, help, default pattern - registry contains a factory method to create the actual parser. This functionality previously was part of Jenkins' warnings plugin but it makes more sense to move it to the analysis-model so that other depending modules can reuse that part as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a registry for all parsers: parsers can be selected using an ID and the registry returns a parser descriptor that provides properties like URL, icon, help, default pattern and a factory method to create the actual parser.
This functionality previously was part of Jenkins' warnings plugin but it makes more sense to move it here so that other depending modules can reuse that part as well.