Revert ssh-credentials that made trilead-api optional

[MarkEWaite]

jenkinsci/ssh-credentials-plugin#199 makes the trilead-api optional. Likely needs some tuning to allow plugin compatibility tests to pass.

This reverts commit 3fb5748.

@olamy can you investigate the two failures? I can duplicate the failures in the plugin bom repository with:

$ PLUGINS=subversion TEST=CompareAgainstBaselineCallableTest bash local-test.sh

$ LINE=weekly PLUGINS=mina-sshd-api-core  bash local-test.sh

[olamy]

subversion plugin jenkinsci/subversion-plugin#284

[MarkEWaite]

subversion plugin jenkinsci/subversion-plugin#284

Thanks very much!

[olamy]

subversion plugin jenkinsci/subversion-plugin#284

Thanks very much!

no worries,
The other one is strange

[ERROR] io.jenkins.plugins.mina_sshd_api.core.authenticators.MinaSSHPublicKeyAuthenticatorTest.testFactory -- Time elapsed: 2.461 s <<< ERROR!
java.lang.NoClassDefFoundError: com/trilead/ssh2/Connection
	at com.cloudbees.jenkins.plugins.sshcredentials.impl.TrileadSSHPasswordAuthenticator$Factory.supports(TrileadSSHPasswordAuthenticator.java:191)
	at com.cloudbees.jenkins.plugins.sshcredentials.impl.TrileadSSHPasswordAuthenticator$Factory.newInstance(TrileadSSHPasswordAuthenticator.java:178)
	at com.cloudbees.jenkins.plugins.sshcredentials.SSHAuthenticator.lambda$newInstance$0(SSHAuthenticator.java:219)

not sure to understand why as we are using this now @OptionalExtension(requirePlugins = {"trilead-api"})
I need to dig into it.

[basil]

Did not take the necessary actions to prevent future updates from being automatically merged as in #3052.

[MarkEWaite]

Thanks. I'll submit a pull request proposing the necessary change.

[MarkEWaite]

The test failure in the subversion plugin is resolved in Subversion plugin pull request:

• Fix missing dependency on directly used trilead-api subversion-plugin#284

[olamy]

btw there seems to be something weird here

[ERROR] io.jenkins.plugins.mina_sshd_api.core.authenticators.MinaSSHPublicKeyAuthenticatorTest.testFactory -- Time elapsed: 2.461 s <<< ERROR!
java.lang.NoClassDefFoundError: com/trilead/ssh2/Connection
	at com.cloudbees.jenkins.plugins.sshcredentials.impl.TrileadSSHPasswordAuthenticator$Factory.supports(TrileadSSHPasswordAuthenticator.java:191)
	at com.cloudbees.jenkins.plugins.sshcredentials.impl.TrileadSSHPasswordAuthenticator$Factory.newInstance(TrileadSSHPasswordAuthenticator.java:178)
	at com.cloudbees.jenkins.plugins.sshcredentials.SSHAuthenticator.lambda$newInstance$0(SSHAuthenticator.java:219)

The code is supposed to lookup only available extensions via this https://github.com/jenkinsci/ssh-credentials-plugin/blob/7fcbaef6194b61fd575d47c1825e56544f20183b/src/main/java/com/cloudbees/jenkins/plugins/sshcredentials/SSHAuthenticator.java#L236

so TrileadSSHPasswordAuthenticator shouldn't be there in the lookup list if trilead-api not available because of @OptionalExtension(requirePlugins = {"trilead-api"}) https://github.com/jenkinsci/ssh-credentials-plugin/blob/7fcbaef6194b61fd575d47c1825e56544f20183b/src/main/java/com/cloudbees/jenkins/plugins/sshcredentials/impl/TrileadSSHPasswordAuthenticator.java#L156

it turns out changing scope is fixing the issue see jenkinsci/mina-sshd-api-plugin#89
looks to be some black magic from PCT :)

[olamy]

I suspect the issue is related to this jenkinsci/maven-hpi-plugin#391
Looks to be some issue with the classpath calculation as Jenkins can see the trilead-api plugin (and so return the optional extension) but the classpath calculation for surefire completely ignores it.