mark trilead api as test (even if we should not need this)

[olamy]

see jenkinsci/bom#3049

Signed-off-by: Olivier Lamy [email protected]

Testing done

Submitter checklist

Beta Give feedback

1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
2. Ensure that the pull request title represents the desired changelog entry
3. Please describe what you did
4. Link to relevant issues in GitHub or Jira
5. Link to relevant pull requests, esp. upstream and downstream changes
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

[jtnord]

jenkinsci/maven-hpi-plugin#391 (comment) ?

[jglick]

I do not follow all the nuances here, but as a procedural request: if it is not clear in advance whether some proposed plugin change will fix something in PCT, or there is some reason to suspect that it might regress something in PCT, please do not file a PR for it as “ready for review” and expect reviewers to catch mistakes or have to revert updates. Instead, file the PR but keep it in draft, wait for an incremental release, and file a draft PR against bom which includes all proposed changes in combination (paste in the URLs in GitHub so we get backlinks) and is marked with a suitable label to run tests on the weekly line or the relevant LTS lines. (Before filing, you can also follow instructions in bom for running selected tests locally.) Only when that is green should the component PRs be opened up for review.

[olamy]

I do not follow all the nuances here, but as a procedural request: if it is not clear in advance whether some proposed plugin change will fix something in PCT, or there is some reason to suspect that it might regress something in PCT, please do not file a PR for it as “ready for review” and expect reviewers to catch mistakes or have to revert updates. Instead, file the PR but keep it in draft, wait for an incremental release, and file a draft PR against bom which includes all proposed changes in combination (paste in the URLs in GitHub so we get backlinks) and is marked with a suitable label to run tests on the weekly line or the relevant LTS lines. (Before filing, you can also follow instructions in bom for running selected tests locally.) Only when that is green should the component PRs be opened up for review.

sure I will change that.
If only Maven have a scope such pct-fix-workaround :)

[olamy]

see jenkinsci/bom#3070

[olamy]

different fix with #98