Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize to Jenkins 2.440.3 #473

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

sghill-rewrite
Copy link
Contributor

@sghill-rewrite sghill-rewrite commented Aug 7, 2024

Hi!

This PR aims to move this plugin to the recommended Jenkins baseline version.

If there are additional requirements for accepting PRs - such as additional lag time before adopting a baseline - feel free to reply in the comments.

Testing done

Ran mvn clean verify.

Submitter checklist

Refs: sghill-rewrite/campaigns#4

Closes #470
Closes #472

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.jenkins.ModernizePlugin?organizationId=SmVua2lucyBDSQ%3D%3D

@sghill-rewrite sghill-rewrite requested a review from a team as a code owner August 7, 2024 05:39
@jglick jglick added the dependencies Pull requests that update a dependency file label Aug 7, 2024
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW @sghill (if you are in fact filing these) are you going to take into account jenkinsci/archetypes#737?

@jglick jglick merged commit bd3184e into jenkinsci:master Aug 7, 2024
16 checks passed
@sghill
Copy link

sghill commented Aug 7, 2024

Thanks for sharing this link! I hadn't seen it. It'd be a good addition to the ModernizePlugin recipe, I'll see if I can add that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants