Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jenkins.baseline variable to reduce manual bom update mistakes #737

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

timja
Copy link
Member

@timja timja commented Jul 24, 2024

see jenkinsci/ssh-credentials-plugin#210 (comment) and its happened plenty of others

Testing done

Works with:

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@timja timja merged commit 983cb63 into jenkinsci:master Jul 24, 2024
2 checks passed
@basil
Copy link
Member

basil commented Jul 24, 2024

Causes #738

MarkEWaite added a commit to MarkEWaite/apache-httpcomponents-client-4-api-plugin that referenced this pull request Jul 24, 2024
Avoid updates to jenkins.version that do not also update the Jenkins
plugin bill of materials version.

jenkinsci/archetypes#737 is the inspiration.
Thanks @timja!
MarkEWaite added a commit to jenkinsci/apache-httpcomponents-client-4-api-plugin that referenced this pull request Jul 24, 2024
Avoid updates to jenkins.version that do not also update the Jenkins
plugin bill of materials version.

jenkinsci/archetypes#737 is the inspiration.
Thanks @timja!
MarkEWaite added a commit to MarkEWaite/versioncolumn-plugin that referenced this pull request Jul 24, 2024
Also define and use jenkins.baseline property

Avoid updates to jenkins.version that do not also update the Jenkins
plugin bill of materials version.

jenkinsci/archetypes#737 is the inspiration.
Thanks @timja!
MarkEWaite added a commit to MarkEWaite/authorize-project-plugin that referenced this pull request Jul 24, 2024
Avoid updates to jenkins.version that do not also update the Jenkins
plugin bill of materials version.

jenkinsci/archetypes#737 is the inspiration.
Thanks @timja!
MarkEWaite added a commit to MarkEWaite/basic-branch-build-strategies-plugin that referenced this pull request Jul 24, 2024
Avoid updates to jenkins.version that do not also update the Jenkins
plugin bill of materials version.

jenkinsci/archetypes#737 is the inspiration.
Thanks @timja!
MarkEWaite added a commit to MarkEWaite/elastic-axis-plugin that referenced this pull request Jul 24, 2024
Avoid updates to jenkins.version that do not also update the Jenkins
plugin bill of materials version.

jenkinsci/archetypes#737 is the inspiration.
Thanks @timja!
MarkEWaite added a commit to MarkEWaite/embeddable-build-status-plugin that referenced this pull request Jul 24, 2024
Avoid updates to jenkins.version that do not also update the Jenkins
plugin bill of materials version.

jenkinsci/archetypes#737 is the inspiration.
Thanks @timja!
MarkEWaite added a commit to MarkEWaite/git-client-plugin that referenced this pull request Jul 24, 2024
Avoid updates to jenkins.version that do not also update the Jenkins
plugin bill of materials version.

jenkinsci/archetypes#737 is the inspiration.
Thanks @timja!
MarkEWaite added a commit to MarkEWaite/git-plugin that referenced this pull request Jul 24, 2024
Avoid updates to jenkins.version that do not also update the Jenkins
plugin bill of materials version.

jenkinsci/archetypes#737 is the inspiration.
Thanks @timja!
MarkEWaite added a commit to MarkEWaite/implied-labels-plugin that referenced this pull request Jul 24, 2024
Avoid updates to jenkins.version that do not also update the Jenkins
plugin bill of materials version.

jenkinsci/archetypes#737 is the inspiration.
Thanks @timja!
MarkEWaite added a commit to MarkEWaite/javadoc-plugin that referenced this pull request Jul 24, 2024
Avoid updates to jenkins.version that do not also update the Jenkins
plugin bill of materials version.

jenkinsci/archetypes#737 is the inspiration.
Thanks @timja!
MarkEWaite added a commit to jenkinsci/versioncolumn-plugin that referenced this pull request Jul 24, 2024
Also define and use jenkins.baseline property

Avoid updates to jenkins.version that do not also update the Jenkins
plugin bill of materials version.

jenkinsci/archetypes#737 is the inspiration.
Thanks @timja!
MarkEWaite added a commit to jenkinsci/elastic-axis-plugin that referenced this pull request Jul 24, 2024
Avoid updates to jenkins.version that do not also update the Jenkins
plugin bill of materials version.

jenkinsci/archetypes#737 is the inspiration.
Thanks @timja!
MarkEWaite added a commit to jenkinsci/embeddable-build-status-plugin that referenced this pull request Jul 24, 2024
Avoid updates to jenkins.version that do not also update the Jenkins
plugin bill of materials version.

jenkinsci/archetypes#737 is the inspiration.
Thanks @timja!
MarkEWaite added a commit to jenkinsci/implied-labels-plugin that referenced this pull request Jul 24, 2024
Avoid updates to jenkins.version that do not also update the Jenkins
plugin bill of materials version.

jenkinsci/archetypes#737 is the inspiration.
Thanks @timja!
MarkEWaite added a commit to jenkinsci/markdown-formatter-plugin that referenced this pull request Jul 24, 2024
Avoid updates to jenkins.version that do not also update the Jenkins
plugin bill of materials version.

jenkinsci/archetypes#737 is the inspiration.
Thanks @timja!
MarkEWaite added a commit to jenkinsci/xshell-plugin that referenced this pull request Jul 24, 2024
Avoid updates to jenkins.version that do not also update the Jenkins
plugin bill of materials version.

jenkinsci/archetypes#737 is the inspiration.
Thanks @timja!
MarkEWaite added a commit to jenkinsci/authorize-project-plugin that referenced this pull request Jul 24, 2024
Avoid updates to jenkins.version that do not also update the Jenkins
plugin bill of materials version.

jenkinsci/archetypes#737 is the inspiration.
Thanks @timja!
MarkEWaite added a commit to jenkinsci/schedule-build-plugin that referenced this pull request Jul 24, 2024
Avoid updates to jenkins.version that do not also update the Jenkins
plugin bill of materials version.

jenkinsci/archetypes#737 is the inspiration.
Thanks @timja!
MarkEWaite added a commit to jenkinsci/testng-plugin-plugin that referenced this pull request Jul 24, 2024
Avoid updates to jenkins.version that do not also update the Jenkins
plugin bill of materials version.

jenkinsci/archetypes#737 is the inspiration.
Thanks @timja!
MarkEWaite added a commit to jenkinsci/nodelabelparameter-plugin that referenced this pull request Jul 24, 2024
Avoid updates to jenkins.version that do not also update the Jenkins
plugin bill of materials version.

jenkinsci/archetypes#737 is the inspiration.
Thanks @timja!
MarkEWaite added a commit to jenkinsci/platformlabeler-plugin that referenced this pull request Jul 24, 2024
Avoid updates to jenkins.version that do not also update the Jenkins
plugin bill of materials version.

jenkinsci/archetypes#737 is the inspiration.
Thanks @timja!
MarkEWaite added a commit to jenkinsci/priority-sorter-plugin that referenced this pull request Jul 24, 2024
Avoid updates to jenkins.version that do not also update the Jenkins
plugin bill of materials version.

jenkinsci/archetypes#737 is the inspiration.
Thanks @timja!
MarkEWaite added a commit to jenkinsci/basic-branch-build-strategies-plugin that referenced this pull request Jul 24, 2024
Avoid updates to jenkins.version that do not also update the Jenkins
plugin bill of materials version.

jenkinsci/archetypes#737 is the inspiration.
Thanks @timja!
MarkEWaite added a commit to jenkinsci/javadoc-plugin that referenced this pull request Jul 24, 2024
Avoid updates to jenkins.version that do not also update the Jenkins
plugin bill of materials version.

jenkinsci/archetypes#737 is the inspiration.
Thanks @timja!
MarkEWaite added a commit to jenkinsci/git-client-plugin that referenced this pull request Jul 24, 2024
Avoid updates to jenkins.version that do not also update the Jenkins
plugin bill of materials version.

jenkinsci/archetypes#737 is the inspiration.
Thanks @timja!
MarkEWaite added a commit to jenkinsci/git-plugin that referenced this pull request Jul 24, 2024
Avoid updates to jenkins.version that do not also update the Jenkins
plugin bill of materials version.

jenkinsci/archetypes#737 is the inspiration.
Thanks @timja!
MarkEWaite added a commit to MarkEWaite/cloud-stats-plugin that referenced this pull request Jul 26, 2024
https://stats.jenkins.io/pluginversions/cloud-stats.html shows that
Jenkins 2.440.3 or newer is already used by 80% of the installations
of the most recent release and the most recent release is used in 75%
of all installations.  Jenkins 2.440.3 also includes a security fix that
is good for users to deploy.

BOM updates have stopped for bom-2.426.x so this will also continue
updating plugin dependencies by switching to a bom version that is still
receiving updates.

Change also removes the duplication of the Jenkins baseline as has been
done recently in the plugin archetype.  Refer to:

* jenkinsci/archetypes#737
MarkEWaite added a commit to jenkinsci/cloud-stats-plugin that referenced this pull request Jul 26, 2024
https://stats.jenkins.io/pluginversions/cloud-stats.html shows that
Jenkins 2.440.3 or newer is already used by 80% of the installations
of the most recent release and the most recent release is used in 75%
of all installations.  Jenkins 2.440.3 also includes a security fix that
is good for users to deploy.

BOM updates have stopped for bom-2.426.x so this will also continue
updating plugin dependencies by switching to a bom version that is still
receiving updates.

Change also removes the duplication of the Jenkins baseline as has been
done recently in the plugin archetype.  Refer to:

* jenkinsci/archetypes#737
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants