-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve integration with Metrics plugin #148
Improve integration with Metrics plugin #148
Conversation
Nice 👍 |
So I'm not sure what to do about testing this. |
Well I'm currently using this PR in combination with my own #149 and while I am seeing:
I'm not seeing the |
This has some tests now, can it be merged? |
incCounters(UNKNOWNCAUSE); | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (!foundCauseList.isEmpty()) {
incCounters(foundCauseList, PluginImpl.getInstance().isMetricSquashingEnabled());
} else {
incCounters(new ArrayList<>(Collections.singletonList(UNKNOWNCAUSE)),
PluginImpl.getInstance().isMetricSquashingEnabled());
}
Using this PR live for some time now. Looks good to me. But I'm not reviewer ;) |
This improves the metrics generated: