Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric category squashing per build feature #149

Conversation

PayBas
Copy link

@PayBas PayBas commented Nov 26, 2021

"Squash failure metrics to unique categories for each build" option can be useful when a single failed build should count towards each cause category exactly once.

This is particularly useful when combined with the "Treat failed test cases as failure causes." If numerous tests fail, "squash failure metrics" will prevent those categories from being incremented for every single failed test, which can skew metrics significantly.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@PayBas PayBas force-pushed the feature/add-metric-category-squashing-per-build-feature branch from fc22a56 to 4cb4689 Compare November 26, 2021 03:36
@PayBas
Copy link
Author

PayBas commented Nov 26, 2021

Alternatively, we could make this the default behavior, which would make this entire PR about 10 lines of code ;)

@TWestling TWestling merged commit 0554a6f into jenkinsci:master Jan 24, 2022
@PayBas PayBas deleted the feature/add-metric-category-squashing-per-build-feature branch January 24, 2022 23:36
@rsandell
Copy link
Member

rsandell commented Feb 4, 2022

@TWestling you forgot to set the label again ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants