[JENKINS-35526] Update to DependencyDeclarer

[fbelzunc]

Basically, I believe this stacktrace is saying that when the maven-plugin is doing getParent().getPublishers() in Runtime is getting ClassCastException because there is something on the list that is not a Publisher. I believe the problem is in the conditional-buildstep-plugin which is doing a cast to DependecyDeclarer - which is deprecated - and DependencyDeclarer needs to be used instead.

udson.util.HudsonFailedToLoad: org.jvnet.hudson.reactor.ReactorException: java.lang.ClassCastException: org.jenkinsci.plugins.conditionalbuildstep.singlestep.SingleConditionalBuilder cannot be cast to hudson.tasks.Publisher 
at hudson.WebAppMain$3.run(WebAppMain.java:237) 
Caused by: org.jvnet.hudson.reactor.ReactorException: java.lang.ClassCastException: org.jenkinsci.plugins.conditionalbuildstep.singlestep.SingleConditionalBuilder cannot be cast to hudson.tasks.Publisher 
at org.jvnet.hudson.reactor.Reactor.execute(Reactor.java:269) 
at jenkins.InitReactorRunner.run(InitReactorRunner.java:44) 
at jenkins.model.Jenkins.executeReactor(Jenkins.java:935) 
at jenkins.model.Jenkins.<init>(Jenkins.java:816) 
at hudson.model.Hudson.<init>(Hudson.java:83) 
at hudson.model.Hudson.<init>(Hudson.java:79) 
at hudson.WebAppMain$3.run(WebAppMain.java:225) 
Caused by: java.lang.ClassCastException: org.jenkinsci.plugins.conditionalbuildstep.singlestep.SingleConditionalBuilder cannot be cast to hudson.tasks.Publisher 
at hudson.maven.MavenModule.getDependencyRelevancy(MavenModule.java:675) 
at hudson.maven.MavenModule.chooseMoreRelevantModule(MavenModule.java:632) 
at hudson.maven.MavenModule.buildDependencyGraph(MavenModule.java:515) 
at hudson.model.DependencyGraph.build(DependencyGraph.java:95) 
at jenkins.model.Jenkins.rebuildDependencyGraph(Jenkins.java:3816) 
at jenkins.model.Jenkins$20.run(Jenkins.java:2742) 
at org.jvnet.hudson.reactor.TaskGraphBuilder$TaskImpl.run(TaskGraphBuilder.java:169) 
at org.jvnet.hudson.reactor.Reactor.runTask(Reactor.java:282) 
at jenkins.model.Jenkins$8.runTask(Jenkins.java:924) 
at org.jvnet.hudson.reactor.Reactor$2.run(Reactor.java:210) 
at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:117) 
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) 
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) 
at java.lang.Thread.run(Unknown Source)

@reviewbybees

[oleg-nenashev]

SingleConditionalBuilder Still implements the DependecyDeclarer

[oleg-nenashev]

I'll let @imod to decide if he cares about such compatibility breakage

[oleg-nenashev]

🐝 from me

[imod]

👍 thats fine with me

[fbelzunc]

@imod Hello, would you mind to merge this?

[ghost]

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

[oleg-nenashev]

@fbelzunc Makes sense to create follow-up bugs to other impacted plugins. https://github.com/search?q=org%3Ajenkinsci+DependecyDeclarer&type=Code