ConditionalBuilder now implements DependencyDeclarer #12
Conversation
SingleConditionalBuilder already implements the correct DependencyDeclarer. This change makes it so that ConditionalBuilder does the same.
|
@TWestling looks good to me - I'll merge is in the next couple of days |
All build steps get added to the dependency graph, no matter what the conditions are. This change remedies this by using the ConditionalDependencyGraphWrapper from the flexible-publish plugin.
|
@imod I noticed that this doesn't work as is for e.g. the parameterized trigger, nor does it work for pull #10 Since we add every builder to the dependencygraph, even if the condition returns false, the graph will make sure that it runs anyway. This is solved in the flexible-publish plugin so the simplest solution is to add a dependency to flexible-publish. I'll add that change to this pull request, please have a look. |
|
@TWestling sorry, I don't like the dependency to the flexible-publish - can't we just do it the same way as it is done there? |
|
@imod I was thinking you would say that :) |
|
@TWestling any plans to finish this? |
|
@imod Yes, this slipped my mind as we started using my version of the plugin and then I forgot about it. I'll reopen it now. |
Copied the needed classes from the flexible publish plugin and removed the dependency from this plugin.
|
@ikedam I've copied two of your classes from the flexible-publish-plugin in order to get the dependency graph to work as it should. I copied them in as they were and just added a note regarding where they came from, I hope this is ok. |
|
@TWestling Looks good to me. |
|
@imod I removed the dependency to the flexible-publisher plugin, could you have a look? |
|
👍 |
SingleConditionalBuilder already implements the correct
DependencyDeclarer. This change makes it so that
ConditionalBuilder does the same.
This is needed to get downstream functionality of e.g. the Junit plugin aggregation and downstream- buildview to work.