-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable cd workflow #35
Conversation
Referring to these docs: https://www.jenkins.io/doc/developer/publishing/releasing-cd/ |
I was wondering if there is really no way to release version only on tag and with tag number 🤔 |
I think you are missing Maybe this template could be tuned to publish only tags and with tag as plugin version? |
😆 Had this locally and didn't noticed that it somehow got ignored from being added. |
Wouldn't the current workflow template create a tag and release on behalf due to "Release drafter"? EDIT: Based on the referenced docs it is possible to exclude at least on-push releases.
So I guess it would also be possible to run this workflow only on tag creation. |
Oh, you are right, it will create tag/release from workflow 😞 I would prefer not to release on every merged PR but manually |
We still need to define secrets for Maven/Artifactory before merging |
This should be added automatically since the infra PR got merged. |
yes, you are right, in fact they already are |
I'm not 100% sure if this really is the case. Regarding the docs there are some labels indicating merges "of interest". As long as there is none of these, the main branch doesn't get released. Maybe I am missing something. |
Do we keep the versioning as if it would be fully automated? |
Yes, I don't think there is other option, imho. If there is maybe it can be somehow done using workflow inputs to specify version number: https://github.blog/changelog/2020-07-06-github-actions-manual-triggers-with-workflow_dispatch/ |
This works pretty well. Have used it a few times. But not with Java projects. EDIT: Referring to https://www.jenkins.io/doc/developer/publishing/releasing-cd/#pom-file-modifications, there are different versioning strategies. I've picked the first but we could do releases with Gitea patches in an automated way using the workflow dispatch feature. |
that acutaly sounds good |
You mean changing the versioning strategy or release with Gitea patches? Or both? 😀 |
I mean manually changing version and than manually triggering release workflow |
b92f23b
to
608a51c
Compare
@lafriks Apologies for the delayed response. 🙂 Concluding all the comments above it seems that we want to manually create tag and then have the GitHub actions automatically craft a release based on that tag and automatically create a changelog using We would have two options regarding version value in
Does this sums it up? If so, I'll modify the scripts according to that. |
Signed-off-by: Steven Kriegler <[email protected]>
Signed-off-by: Steven Kriegler <[email protected]>
Co-authored-by: Lauris BH <[email protected]>
608a51c
to
c2e71b9
Compare
@lafriks Hrm... I struggle to understand how the described behavior can be integrated into the current workflow without knowing how exactly it behaves. How about first see the current release in action before changing the automation? There won't be automatic releases since the workflow only reacts to dispatch events, so we have full control over it right now. As discussed above, I've changed the If this is ok for you, then let's find out what happens. 🙈 |
Ok, let's see what happens :) |
* Enable cd workflow (#35) * Enable cd workflow Signed-off-by: Steven Kriegler <[email protected]> * Add missing GitHub workflow Signed-off-by: Steven Kriegler <[email protected]> * Update .github/workflows/cd.yaml Co-authored-by: Lauris BH <[email protected]> * Switch back to classic version syntax Co-authored-by: Lauris BH <[email protected]> * Bump version to 1.5.0 (jenkinsci#42) Additionally: Fix tag/release template to match previous releases * Fix release versioning + incremental builds (jenkinsci#43) * Add alt-texts to badges This is a commit for letting the status checks fail. * Lower the release version * Re-Add changelist to version * Opt-out incremental suffix during release See: jenkins-infra/jenkins-maven-cd-action#13 * Auto-incrementalify after release * Fix JENKINS-67068 (jenkinsci#44) As a result of PR #29 it happens that some users cannot fetch branches with slashes in their names anymore. Regression from: JENKINS-65796 Co-authored-by: Steven <[email protected]> Co-authored-by: Lauris BH <[email protected]>
Most of the plugins I use fully migrated to JEP-229[^1]. It seems stable enough and reduces manual overhead when releasing the plugin. After quick chat with @lafriks in Discord, we decided to fully enable automated releases. The first part happened in #35. I followed the official docs[^2]. This will change the versioning pattern to `<amount-of-commits-on-main-branch>.v<HEAD>`. When the next release is crafted, we should add a note to the relase about this version change. I also configured Dependabot to get monthly updates for our dependencies. [^1]: https://github.com/jenkinsci/jep/blob/master/jep/229/README.adoc [^2]: https://www.jenkins.io/doc/developer/publishing/releasing-cd/ Signed-off-by: justusbunsi <[email protected]>
Most of the plugins I use fully migrated to JEP-229[^1]. It seems stable enough and reduces manual overhead when releasing the plugin. After quick chat with @lafriks in Discord, we decided to fully enable automated releases. The first part happened in #35. I followed the official docs[^2]. This will change the versioning pattern to `<amount-of-commits-on-main-branch>.v<HEAD>`. When the next release is crafted, we should add a note to the relase about this version change. I also configured Dependabot to get monthly updates for our dependencies. [^1]: https://github.com/jenkinsci/jep/blob/master/jep/229/README.adoc [^2]: https://www.jenkins.io/doc/developer/publishing/releasing-cd/ Signed-off-by: justusbunsi <[email protected]>
To reduce manual overhead on releases, this can be automated.