[JENKINS-63078] Allow ignoring rate limits #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwiseman
reviewed
Jul 17, 2020
src/main/resources/org/jenkinsci/plugins/github_branch_source/Messages.properties
Outdated
Show resolved
Hide resolved
bitwiseman
reviewed
Jul 17, 2020
|
|
||
| @Override | ||
| public void checkApiRateLimit(@NonNull TaskListener listener, GitHub github) throws IOException, InterruptedException { | ||
| // Nothing needed |
There was a problem hiding this comment.
If pointing at https://github.com this setting should pass through to ThrottleOnOver. There is literally never a reason to not check rate limits when interacting with github.com.
There was a problem hiding this comment.
Should we block the selection of NoThrottle in the config page if the api uri is github.com?
edit: actually scratch that. For some reason I forgot you can add mulitple servers
bitwiseman
reviewed
Jul 17, 2020
| // there should be no output | ||
| assertEquals(0, countOfOutputLines(m -> m.matches("[sS]leeping"))); | ||
| // github rate_limit endpoint should not be contacted | ||
| githubApi.verify(0, RequestPatternBuilder.newRequestPattern(RequestMethod.GET, urlPathEqualTo("/rate_limit"))); |
bitwiseman
requested changes
Jul 17, 2020
sirstrahd
force-pushed
the
allow_ignoring_rate_limits
branch
from
2337247
to
3602bf6
Compare
sirstrahd
force-pushed
the
allow_ignoring_rate_limits
branch
from
3602bf6
to
7b39521
Compare
|
I added the requested behaviour. Added a test for it + took the chance to fix a couple wrong regexs from other test assertions. |
bitwiseman
approved these changes
Aug 5, 2020
car-roll
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds ApiRateLimitChecker.NoThrottle, which avoids checking the GitHub rate limits. This is useful for GitHub Enterprise installations. See JENKINS-63078 for further information.
When this change is included, a new strategy will appear on the Github API usage rate limiting strategy selector, called NoThrottle, with the description Ignore rate limit. No requests to the rate_limit endpoint should be performed if it is selected.
Submitter checklist
Reviewer checklist
Documentation changes
Users/aliases to notify