-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-63078] Allow ignoring rate limits #313
Merged
bitwiseman
merged 7 commits into
jenkinsci:master
from
sirstrahd:allow_ignoring_rate_limits
Aug 19, 2020
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6807c31
Adds new ApiRateLimitChecker that ignores rate_limits
7c3c9a1
Rename ThrottleNone to NoThrottle
a99e7a3
Improve test for ApiRateLimitChecker.NoThrottle
b88408f
More explicit warning on selector for ApiRateLimitChecker.NoThrottle
sirstrahd 7b39521
NoThrottle will now redirect to ThrottleOnOver if GitHub.com api dete…
bdec8b6
Merge branch 'master' into allow_ignoring_rate_limits
bitwiseman 5e39143
Merge branch 'master' into allow_ignoring_rate_limits
bitwiseman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If pointing at
https://github.com
this setting should pass through toThrottleOnOver
. There is literally never a reason to not check rate limits when interacting withgithub.com
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we block the selection ofNoThrottle
in the config page if the api uri is github.com?edit: actually scratch that. For some reason I forgot you can add mulitple servers