Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve queue restart tests #6453

Merged
merged 1 commit into from
Apr 10, 2022
Merged

Improve queue restart tests #6453

merged 1 commit into from
Apr 10, 2022

Conversation

basil
Copy link
Member

@basil basil commented Apr 9, 2022

This PR moves QueueRestartTest#persistQueueOnCrash to a separate test class (QueueCrashTest, still based on RestartableJenkinsRule) so that we can convert QueueRestartTest to RealJenkinsRule and make it more realistic. Once migrated to RealJenkinsRule, we make QueueRestartTest test the more realistic scenario of a user quieting down Jenkins (with a Groovy initialization script), restarting Jenkins (possibly multiple times, presumably to update plugins), and finally unquieting Jenkins and waiting for the queued build to finish.

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change) and are in the imperative mood. Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadoc, as appropriate.
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@basil basil added skip-changelog Should not be shown in the changelog squash-merge-me Unclean or useless commit history, should be merged only with squash-merge labels Apr 9, 2022
@basil
Copy link
Member Author

basil commented Apr 10, 2022

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process. Thanks!

@basil basil added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Apr 10, 2022
@basil basil merged commit cb64da5 into jenkinsci:master Apr 10, 2022
@basil basil deleted the queue branch April 10, 2022 17:37
@basil basil mentioned this pull request Jun 26, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog squash-merge-me Unclean or useless commit history, should be merged only with squash-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants