Ignore hudson.model.QueueRestartTest
#6705
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added these tests in #6453, and after debugging the tests I believe the tests are correct and that the race condition is in the code under test (i.e., Jenkins core). This is tracked in JENKINS-68319. I managed to reproduce the problem locally once or twice, but then after that I failed to reproduce it locally after dozens of tries. Our CI builds appear to be doing a good job of hitting it:
Hitting this in PR builds doesn't tell us anything that we don't already know (i.e., the problem exists) and it doesn't help us debug the problem, but it does slow down the integration of new PRs. Therefore, I think it is in our best short-term interests to ignore these tests. I also think it is only a matter of time before the underlying bug causes further issues, so I think it is in our best long-term interests for a someone (especially an existing or aspiring member of the core team) to debug and resolve the underlying issue.
Proposed changelog entries
N/A
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entries
section only if there are breaking changes or other changes which may require extra steps from users during the upgrade@Restricted
or have@since TODO
Javadoc, as appropriate.@Deprecated(since="TODO")
or@Deprecated(since="TODO", forRemoval=true)
if applicable.Desired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge
:Proposed changelog entries
are accurate, human-readable, and in the imperative moodupgrade-guide-needed
label is set and there is aProposed upgrade guidelines
section in the PR title. (example)lts-candidate
to be considered (see query).