Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore hudson.model.QueueRestartTest #6705

Merged
merged 1 commit into from
Jun 26, 2022
Merged

Conversation

basil
Copy link
Member

@basil basil commented Jun 26, 2022

I added these tests in #6453, and after debugging the tests I believe the tests are correct and that the race condition is in the code under test (i.e., Jenkins core). This is tracked in JENKINS-68319. I managed to reproduce the problem locally once or twice, but then after that I failed to reproduce it locally after dozens of tries. Our CI builds appear to be doing a good job of hitting it:

Hitting this in PR builds doesn't tell us anything that we don't already know (i.e., the problem exists) and it doesn't help us debug the problem, but it does slow down the integration of new PRs. Therefore, I think it is in our best short-term interests to ignore these tests. I also think it is only a matter of time before the underlying bug causes further issues, so I think it is in our best long-term interests for a someone (especially an existing or aspiring member of the core team) to debug and resolve the underlying issue.

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change) and are in the imperative mood. Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadoc, as appropriate.
  • New deprecations are annotated with @Deprecated(since="TODO") or @Deprecated(since="TODO", forRemoval=true) if applicable.
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@basil basil added the skip-changelog Should not be shown in the changelog label Jun 26, 2022
@basil basil added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jun 26, 2022
@basil
Copy link
Member Author

basil commented Jun 26, 2022

I plan to merge this once I get a green build to unblock other PRs.

@basil basil merged commit 5b42b47 into jenkinsci:master Jun 26, 2022
@basil basil deleted the QueueRestartTest branch June 26, 2022 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants