Revert "Improve breadcrumb bar accessibility" #7525
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this thread. The Jenkins core maintainers aspire to deliver First Customer Ship (FCS) quality all the time on the main branch. The integration of #6912 has destabilized the main branch, resulting in approximately a dozen pull requests to correct issues with the initial integration. When the main branch is not in a stable state, new problems are far more likely to be introduced, a timeless phenomenon described by Jeff Bonwick as the Quality Death Spiral. The overall quality of the delivered software, not any one project, is what matters; therefore, this PR reverts #6912.
There is past precedent for this: when the Jetty 10 upgrade was integrated, it destabilized the main branch. It was quickly reverted, then reintegrated later when all known issues had been addressed. The revert of #6912 is also intended to be temporary: once the issues caused by the original change are addressed (including JENKINS-70169, JENKINS-70255, and jenkinsci/design-library-plugin#182), we fully hope and expect for it to be reintegrated and delivered in its final form.
The original author of #6912 has offered a partial revert instead of a full one in #6912 (comment). It is unclear to me whether the partial revert would address JENKINS-70169, JENKINS-70255, and jenkinsci/design-library-plugin#182. If it addresses all three issues and is completed prior to the release of 2.383, this would address my concerns and this PR could be closed. If a partial revert does not address all three issues or if it is not completed prior to the release of 2.383, I would like to proceed with a full revert for 2.383 as in this PR.
Testing done
Built core with these changes and verified that the console output page looked the same as it did prior to #6912.
Proposed changelog entries
Restore breadcrumb navigation behavior from 2.374 and earlier.
Proposed upgrade guidelines
N/A
Submitter checklist
@Restricted
or have@since TODO
Javadocs, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
, if applicable.eval
to ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge
:upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).