-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JENKINS-70169 Restore link to last breadcrumb #7539
Conversation
Are we confident that any potential problems with this PR will be addressed promptly? 2.383 shipped with this issue, despite a mailing list thread and pull request (#7525) that attempted to avoid this suboptimal outcome prior to the release of 2.383. |
I am confident in the fix. I don't see any attempts by that pull request to get merged by 2.383, none of the people involved in the original pull request were requested for review or notified. It's the Christmas period so I will not commit to anything but I am -1 for a revert of the original PR. |
The fact that #6912 (comment) and #7525 remain unacknowledged for approximately one week does not give me confidence that others are actively paying attention to the content of weekly releases. The veto of #7525 in #7539 (comment) does not contain a technical justification for why #7525 is bad, so by Apache rules it is invalid and has no weight. It also remains unclear to me whether jenkinsci/design-library-plugin#182 was a preëxisting issue exposed by #6912 (and therefore hidden again by this PR) or an API change introduced by #6912 (and therefore still unsolved by this PR). |
I gave it a practical test earlier, and it does restore breadcrumbs missing breadcrumbs indeed, like outlined on the issue. |
This is the Jenkins project. Not the Apache project. jenkinsci/design-library-plugin#182 was pre-existing and is an enhancement request not a blocker for anything. |
Thanks for the fix @timja. I've just moved house in the last week (plus the joy of no internet) so I've had little time to spend on Jenkins. |
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
(cherry picked from commit de35224)
(cherry picked from commit de35224)
See JENKINS-70169.
Alternative to #7525
Testing done
Clicked the breadcrumb on the console log page.
Checked around a number of other pages like Plugin Manager, new item page etc
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
@Restricted
or have@since TODO
Javadocs, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
, if applicable.eval
to ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge
:upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).