JENKINS-70169 Restore link to last breadcrumb

[timja]

See JENKINS-70169.

Alternative to #7525

Testing done

Clicked the breadcrumb on the console log page.
Checked around a number of other pages like Plugin Manager, new item page etc

Proposed changelog entries

• JENKINS-70169 Restore link to last breadcrumb

Proposed upgrade guidelines

N/A

Submitter checklist

• The Jira issue, if it exists, is well-described.
• The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
  • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
• There is automated testing or an explanation as to why this change has no tests.
• New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
• New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
• New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
• For dependency updates, there are links to external changelogs and, if possible, full differentials.
• For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

• There are at least two (2) approvals for the pull request and no outstanding requests for change.
• Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
• Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
• Proper changelog labels are set so that the changelog can be generated automatically.
• If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
• If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[basil]

Are we confident that any potential problems with this PR will be addressed promptly? 2.383 shipped with this issue, despite a mailing list thread and pull request (#7525) that attempted to avoid this suboptimal outcome prior to the release of 2.383.

[timja]

I am confident in the fix. I don't see any attempts by that pull request to get merged by 2.383, none of the people involved in the original pull request were requested for review or notified.

It's the Christmas period so I will not commit to anything but I am -1 for a revert of the original PR.

[basil]

The fact that #6912 (comment) and #7525 remain unacknowledged for approximately one week does not give me confidence that others are actively paying attention to the content of weekly releases. The veto of #7525 in #7539 (comment) does not contain a technical justification for why #7525 is bad, so by Apache rules it is invalid and has no weight. It also remains unclear to me whether jenkinsci/design-library-plugin#182 was a preëxisting issue exposed by #6912 (and therefore hidden again by this PR) or an API change introduced by #6912 (and therefore still unsolved by this PR).

[NotMyFault]

I am confident in the fix.

I gave it a practical test earlier, and it does restore breadcrumbs missing breadcrumbs indeed, like outlined on the issue.

[timja]

remain unacknowledged for approximately one week

none of the people involved in the original pull request were requested for review or notified.

so by Apache rules it is invalid and has no weight

This is the Jenkins project. Not the Apache project.

jenkinsci/design-library-plugin#182 was pre-existing and is an enhancement request not a blocker for anything.

[janfaracik]

Thanks for the fix @timja. I've just moved house in the last week (plus the joy of no internet) so I've had little time to spend on Jenkins.

[timja]

/label ready-for-merge

---

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!