Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use jenkins.baseline property to avoid BOM update mistakes #340

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Use jenkins.baseline property to avoid BOM update mistakes #340

merged 1 commit into from
Jul 24, 2024

Conversation

MarkEWaite
Copy link
Contributor

Use jenkins.baseline property to avoid BOM update mistakes

Avoid updates to jenkins.version that do not also update the Jenkins plugin bill of materials version.

Inspired by:

Testing done

Confirmed that mvn help:effective-pom after the change matches expected values.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@MarkEWaite
Define and use jenkins.baseline property
20331c4 
Avoid updates to jenkins.version that do not also update the Jenkins
plugin bill of materials version.

jenkinsci/archetypes#737 is the inspiration.
Thanks @timja!
@MarkEWaite MarkEWaite requested a review from a team as a code owner July 24, 2024 20:19
@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label Jul 24, 2024
@github-actions github-actions bot added the dependencies Dependency related change label Jul 24, 2024
@MarkEWaite MarkEWaite merged commit 04ee886 into jenkinsci:master Jul 24, 2024
17 checks passed
@MarkEWaite MarkEWaite deleted the add-jenkins.baseline-property branch July 24, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chore Reduces maintenance effort by changes not directly visible to users dependencies Dependency related change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MarkEWaite