Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make reports a hierarchical data structure #872

Merged
merged 40 commits into from
Apr 11, 2021
Merged

Make reports a hierarchical data structure #872

merged 40 commits into from
Apr 11, 2021

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Apr 6, 2021

In analysis-model a new registry has been added in jenkinsci/analysis-model#572.
- parsers can be selected using an ID
- registry returns a parser descriptor that provides properties like URL, icon, help, default pattern
- registry contains a factory method to create the actual parser.

This functionality previously was part of Jenkins' warnings plugin but it makes more sense to move it
to the analysis-model so that other depending modules can reuse that part as well.
Introduce new base class for tools that are based on
parsers of the analysis model library.
@uhafner uhafner added the enhancement Enhancement of existing functionality label Apr 6, 2021
@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #872 (19a0422) into master (1122db1) will decrease coverage by 0.26%.
The diff coverage is 94.28%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #872      +/-   ##
============================================
- Coverage     80.20%   79.93%   -0.27%     
+ Complexity     1561     1413     -148     
============================================
  Files           243      237       -6     
  Lines          5664     5199     -465     
  Branches        422      406      -16     
============================================
- Hits           4543     4156     -387     
+ Misses          965      893      -72     
+ Partials        156      150       -6     
Impacted Files Coverage Δ Complexity Δ
...io/jenkins/plugins/analysis/warnings/AcuCobol.java 100.00% <ø> (ø) 1.00 <0.00> (-1.00)
...java/io/jenkins/plugins/analysis/warnings/Ajc.java 100.00% <ø> (ø) 1.00 <0.00> (-1.00)
...jenkins/plugins/analysis/warnings/AnsibleLint.java 100.00% <ø> (+14.28%) 1.00 <0.00> (-1.00) ⬆️
...va/io/jenkins/plugins/analysis/warnings/ArmCc.java 100.00% <ø> (ø) 1.00 <0.00> (-1.00)
...jenkins/plugins/analysis/warnings/Buckminster.java 100.00% <ø> (ø) 1.00 <0.00> (-1.00)
.../io/jenkins/plugins/analysis/warnings/Cadence.java 100.00% <ø> (ø) 1.00 <0.00> (-1.00)
...va/io/jenkins/plugins/analysis/warnings/Cargo.java 100.00% <ø> (+14.28%) 1.00 <0.00> (-1.00) ⬆️
...java/io/jenkins/plugins/analysis/warnings/Ccm.java 80.00% <ø> (-5.72%) 1.00 <0.00> (-1.00)
...va/io/jenkins/plugins/analysis/warnings/Clair.java 83.33% <ø> (+13.33%) 1.00 <0.00> (-1.00) ⬆️
...va/io/jenkins/plugins/analysis/warnings/Clang.java 100.00% <ø> (ø) 1.00 <0.00> (-1.00)
... and 126 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1122db1...19a0422. Read the comment docs.

@uhafner uhafner merged commit 85d1b92 into master Apr 11, 2021
@uhafner uhafner deleted the sub-reports branch April 11, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant