Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
mapto_ibz
,uc_point
was not transformed to the Cartesian basis if fractional coordinates were used. Additionally, there was a typo in the function signature of the array-version ofmapto_ibz
which madeatol
andrtol
optional- instead of keyword arguments.Furthermore, I slightly shortened
mapto_bz
and switched around the order of the shifts such that no shift takes precedence when a point is mapped to the Brillouin zone.