Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in mapto_ibz #20

Merged
merged 5 commits into from
Dec 16, 2023
Merged

Fix bug in mapto_ibz #20

merged 5 commits into from
Dec 16, 2023

Conversation

androme-dan
Copy link
Contributor

In mapto_ibz, uc_point was not transformed to the Cartesian basis if fractional coordinates were used. Additionally, there was a typo in the function signature of the array-version of mapto_ibz which made atol and rtol optional- instead of keyword arguments.

Furthermore, I slightly shortened mapto_bz and switched around the order of the shifts such that no shift takes precedence when a point is mapped to the Brillouin zone.

@jerjorg jerjorg merged commit b9f21a6 into jerjorg:master Dec 16, 2023
7 checks passed
@lxvm lxvm mentioned this pull request Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants