Feature: Add support for `.rejects.toThrowWithMessage` #315

GerkinDev · 2021-04-27T08:27:08Z

What

This feature adds suport for expect(promise).rejects.toThrowWithMessage, which previously throwed because passed tested value was not a function. This test is now conditionnaly skipped if the matcher is called from rejects.

Why

Closes #219

Notes

This change required an update to jest@^24.0.0 to use features mentioned in the corresponding changelog, and in particular this PR.

This update of jest required an update of babel-jest@^24.0.0, which is incopatible with babel-core@^6.26.0. Thus, babel-core & babel-cli were removed and replaced with @babel/core@^7.0.0 & @babel/cli@^7.0.0, and use of @babel/preset-env@^7.0.0. All changes in babel/build-related deps are a direct result of those chained required updates.

This PR is directly installable as a dependency in projects with:

npm install --save-dev git+https://github.com/GerkinDev/jest-extended.git#build/rejects-toThrowWithMessage

Housekeeping

Unit tests
Documentation is up to date
No additional lint warnings
Typescript definitions are added/updated where relevant

imjordanxd · 2021-06-28T03:54:08Z

@GerkinDev any updates on this? I can see you have conflicts.

GerkinDev · 2021-06-28T07:50:27Z

Looks like the original maintainers did some changes 2 weeks ago in 4849c57 creating the conflict.

Problem is, this PR has a counterpart PR https://github.com/keeganwitt/jest-extended/pull/57 in a forked repo, and I don't know which will be updated or not. Both repositories have recent changes by @keeganwitt and are not in sync. Thus, I would have to create 2 separate PRs with 2 separate git history to match each repo, and I won't do that.

@keeganwitt can you please do something ? Rebase one on the other, or do a merge of some sort, or tell me which repo is the most likely to integrate this PR ? Conflicts are purely on version changes, mine having updated babel@>=7.0.0 while jest-community/jest-extended@master is still on [email protected]. But this PR also uses jest@>=24.0.0 (on master since 4849c57).
So yeah please tell me what I should do, thanks 🍻

keeganwitt · 2021-06-28T12:45:53Z

I made a fork and started merging MRs into it because I wasn't sure the status of this repo and whether it was still maintained and would get stuff merged. Now that I've found it's in fact not abandoned, my fork should be unnecessary.

I'll close the MRs in my fork, to help avoid the confusion (and once my MRs here are merged, delete my fork to clean up those references).

GerkinDev · 2021-06-28T12:50:39Z

@keeganwitt do you know who is in charge of this repo and active then ? I'll resolve conflict asap once I know it wont have time to have other conflicts again. Time is precious

keeganwitt · 2021-06-28T13:02:16Z

@keeganwitt do you know who is in charge of this repo and active then?

I don't think specific people have said "I'll be handling this work" at this time, and I don't want to speak for others. But there are people with access (I was originally concerned no one besides Matt had access). Sorry that I don't have a more specific answer.

GerkinDev · 2021-06-28T14:56:17Z

Okay then, so I'm waiting here with my hand raised hoping someone will ping me soon

rickhanlonii · 2021-06-28T15:05:40Z

@GerkinDev just to clarify, this project is in jest-community, so all of the Jest contributors help maintain it.

rickhanlonii · 2021-06-28T15:09:04Z

README.md

-    - [.toBeAfter(date)](#tobeafterdate)
-    - [.toBeBefore(date)](#tobebeforedate)
-    - Further proposals in [#117](https://github.com/jest-community/jest-extended/issues/117) PRs welcome
+  - [~~Date~~](#date)


This formatting doesn't appear to be correct

If I remember correctly, this was auto generated by tooling, not by hand. I'm not sure what I should do to fix formatting.

rickhanlonii · 2021-06-28T15:09:38Z

README.md

@@ -435,7 +437,7 @@ test('passes when value is a function', () => {
 Use `.toThrowWithMessage` when checking if a callback function throws an error with a given error type and given error message. Message can either be a `String` or a `RegExp`.

 ```js
-test('throws an error of type TypeError with message "hello world"', () => {
+test('throws an error of type TypeError with message "hello world"', async () => {


Can you make this a separate test instead?

Applied in a05d5ce

rickhanlonii · 2021-06-28T15:10:43Z

package.json

@@ -35,23 +35,22 @@
  "license": "MIT",
  "repository": "jest-community/jest-extended",
  "devDependencies": {
+    "@babel/cli": "^7.0.0",


I'm hesitant to change the babel setup in this PR because it's unrelated. Can you revert and handle separately? @keeganwitt has been working on the babel upgrade in a separate stream of work.

That's #327 for reference, which is blocked pending #328.

As mentionned in the PR description, this bump is a direct dependency of the update of babel-jest@>=24.0.0, required because jest@>=24.0.0 exposes context properties allowing specific behavior depending on the async context. I doubt this PR could be done reliabily and being compatible with jest@^23.0.0 & jest@^24.0.0.

rickhanlonii · 2021-06-28T15:11:19Z

package.json

    "eslint": "^4.9.0",
    "eslint-plugin-import": "^2.8.0",
    "eslint-plugin-jest": "^21.2.0",
    "husky": "^0.14.3",
    "import-all.macro": "^2.0.3",
-    "jest": "^23.0.1",
+    "jest": "^24.0.0",


This seems like a breaking change.

That's a dev dependency, and master is already bumped to 24.

keeganwitt · 2021-06-28T22:05:39Z

@GerkinDev just to clarify, this project is in jest-community, so all of the Jest contributors help maintain it.

Yes, sorry if that was unclear in my response. No specific person(s) has taken primary responsibility, but it continues to be collectively maintained by the team. There just isn't any specific people to @.

GerkinDev · 2021-07-13T15:38:55Z

Up ?

corbetchri · 2021-08-11T23:28:38Z

Hey team - any idea when this will go through? Would love to use this change. Thank you

GerkinDev · 2021-08-24T23:31:59Z

Up. More and more conflicts....

GerkinDev · 2021-09-02T15:16:17Z

Rebased on latest main.

SimenB

thanks!

could you remove the changes in package.json and the lockfile? They should be needed (and are updated in main) 🙂

Application of feedback #315 (comment)

GerkinDev · 2021-10-06T20:45:37Z

@SimenB here you are ! Rebased and pruned from useless chore !

codecov · 2021-10-11T07:31:20Z

Codecov Report

Merging #315 (2497be4) into main (ee70268) will increase coverage by 100.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           main      #315        +/-   ##
===========================================
+ Coverage      0   100.00%   +100.00%     
===========================================
  Files         0       117       +117     
  Lines         0       681       +681     
  Branches      0       108       +108     
===========================================
+ Hits          0       681       +681

Impacted Files	Coverage Δ
src/matchers/toThrowWithMessage/index.js	`100.00% <100.00%> (ø)`
src/matchers/toBeFalse/predicate.js	`100.00% <0.00%> (ø)`
src/matchers/toContainAllValues/index.js	`100.00% <0.00%> (ø)`
src/matchers/toHaveBeenCalledAfter/predicate.js	`100.00% <0.00%> (ø)`
src/matchers/toBeHexadecimal/index.js	`100.00% <0.00%> (ø)`
src/matchers/toBeDate/predicate.js	`100.00% <0.00%> (ø)`
src/matchers/toBeFunction/index.js	`100.00% <0.00%> (ø)`
src/matchers/toBeEmpty/predicate.js	`100.00% <0.00%> (ø)`
src/matchers/toBeNaN/predicate.js	`100.00% <0.00%> (ø)`
src/matchers/toContainAnyKeys/predicate.js	`100.00% <0.00%> (ø)`
... and 108 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee70268...2497be4. Read the comment docs.

SimenB · 2021-10-11T07:31:59Z

Thank you, and thanks for your patience here!

GerkinDev mentioned this pull request Apr 27, 2021

toThrowWithMessage does not work with promise #219

Closed

rickhanlonii approved these changes Jun 28, 2021

View reviewed changes

SimenB approved these changes Oct 6, 2021

View reviewed changes

GerkinDev added 2 commits October 6, 2021 22:43

feat: add support for .rejects.toThrowWithMessage

94423c6

docs: update readme, split async test

2497be4

Application of feedback #315 (comment)

SimenB merged commit cbdbe11 into jest-community:main Oct 11, 2021

GerkinDev deleted the feature/rejects-toThrowWithMessage branch October 11, 2021 14:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: Add support for `.rejects.toThrowWithMessage` #315

Feature: Add support for `.rejects.toThrowWithMessage` #315

GerkinDev commented Apr 27, 2021 •

edited

Loading

imjordanxd commented Jun 28, 2021

GerkinDev commented Jun 28, 2021

keeganwitt commented Jun 28, 2021

GerkinDev commented Jun 28, 2021

keeganwitt commented Jun 28, 2021

GerkinDev commented Jun 28, 2021

rickhanlonii commented Jun 28, 2021

rickhanlonii Jun 28, 2021

GerkinDev Jun 28, 2021 •

edited

Loading

rickhanlonii Jun 28, 2021

GerkinDev Jun 28, 2021

rickhanlonii Jun 28, 2021

keeganwitt Jun 28, 2021

GerkinDev Jun 28, 2021

rickhanlonii Jun 28, 2021

keeganwitt Jun 28, 2021

keeganwitt commented Jun 28, 2021 •

edited

Loading

GerkinDev commented Jul 13, 2021

corbetchri commented Aug 11, 2021

GerkinDev commented Aug 24, 2021

GerkinDev commented Sep 2, 2021

SimenB left a comment

GerkinDev commented Oct 6, 2021

codecov bot commented Oct 11, 2021 •

edited

Loading

SimenB commented Oct 11, 2021

Feature: Add support for .rejects.toThrowWithMessage #315

Feature: Add support for .rejects.toThrowWithMessage #315

Conversation

GerkinDev commented Apr 27, 2021 • edited Loading

What

Why

Notes

Housekeeping

imjordanxd commented Jun 28, 2021

GerkinDev commented Jun 28, 2021

keeganwitt commented Jun 28, 2021

GerkinDev commented Jun 28, 2021

keeganwitt commented Jun 28, 2021

GerkinDev commented Jun 28, 2021

rickhanlonii commented Jun 28, 2021

Choose a reason for hiding this comment

GerkinDev Jun 28, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

keeganwitt commented Jun 28, 2021 • edited Loading

GerkinDev commented Jul 13, 2021

corbetchri commented Aug 11, 2021

GerkinDev commented Aug 24, 2021

GerkinDev commented Sep 2, 2021

SimenB left a comment

Choose a reason for hiding this comment

GerkinDev commented Oct 6, 2021

codecov bot commented Oct 11, 2021 • edited Loading

Codecov Report

SimenB commented Oct 11, 2021

Feature: Add support for `.rejects.toThrowWithMessage` #315

Feature: Add support for `.rejects.toThrowWithMessage` #315

GerkinDev commented Apr 27, 2021 •

edited

Loading

GerkinDev Jun 28, 2021 •

edited

Loading

keeganwitt commented Jun 28, 2021 •

edited

Loading

codecov bot commented Oct 11, 2021 •

edited

Loading