Update Husky and linting configuration

[keeganwitt]

What

Update Husky and fix linting configuration.

Why

Linting is not being performed currently by the Git hook.

[mattphillips]

I'm not sure I agree with removing the pre-commit hook. Typically I am also against them when they are blocking but in this case all it does is run prettier on the staged changes and is non-blocking.

I agree that it would be good to add a prettier based check to CI also to check consistency as pre-commit hooks are skippable something like: https://prettier.io/docs/en/cli.html#--check

[rickhanlonii]

Non-blocking is ok I guess - we should definitely add a check to CI though.

[keeganwitt]

Updated to update Husky and the linting configuration so that it runs, rather than removing Husky. Let me know if this isn't what you had in mind.

[codecov]

Codecov Report

Merging #328 (00e6e85) into main (a0d7d65) will not change coverage.
The diff coverage is n/a.

❗ Current head 00e6e85 differs from pull request most recent head 9587ebf. Consider uploading reports for the commit 9587ebf to get more accurate results

@@            Coverage Diff            @@
##              main      #328   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          109       109           
  Lines          636       636           
  Branches       100       100           
=========================================
  Hits           636       636           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0d7d65...9587ebf. Read the comment docs.

[keeganwitt]

This probably isn't the best way to fix this, but I tried adding

"endOfLine": "auto",

to prettier in package.json. but I was still getting lint warnings (on Windows with core.autocrlf true).

[rickhanlonii]

Would be good to figure out how to not do this, no project I've used with prettier needs it so I'm skeptical that this is the best solution.

[rickhanlonii]

LGTM

[SimenB]

note that this didn't actually run - had to chmod it: 44b9e6c