Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recent list to skip tokens #906

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Fix recent list to skip tokens #906

merged 2 commits into from
Sep 5, 2023

Conversation

saghul
Copy link
Member

@saghul saghul commented Sep 5, 2023

No description provided.

It can happen if DNS resolution fails, for example.
@saghul saghul requested a review from csett86 September 5, 2023 09:39
@saghul
Copy link
Member Author

saghul commented Sep 5, 2023

@csett86 PTAL. I made it so all entried will be normalized after a meeting is updated.

Copy link
Member

@csett86 csett86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, a quick test also worked well, thank you @saghul

@csett86 csett86 merged commit 624e1f8 into master Sep 5, 2023
3 checks passed
@csett86 csett86 deleted the fix-recent-list branch September 5, 2023 21:07
@damencho
Copy link
Member

We got a question about this in the community call, is it possible to keep the config options and just drop the jwt?

@saghul
Copy link
Member Author

saghul commented Mar 18, 2024

It should be possible, yeah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jwt login token part of 'recent rooms', but expires on meet.jit.si within an hour
3 participants