Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: seperate is not an english word. It should be separate. #139

Closed
wants to merge 2 commits into from
Closed

Fix: seperate is not an english word. It should be separate. #139

wants to merge 2 commits into from

Conversation

fernandezc
Copy link
Contributor

However, this fix, made in several comments, also affects the name of a function: seperate_interleaved.
So I marked the original as obsolete and created a new one: separate_interleaved which is intended to replace the previous one in future versions.

It is not a critical PR, so it can be ignored without any problem.

Additional changes :
A deprecated decorator has been added in util/misc.

@fernandezc
Correction of a typo: seperate should be separate.
4dddd6b 
AS it affect the name of one function, I made the original one
deprecated and create a new one: `separate_interleaved` which is
intended to replace the previous `seperate_interleaved` in
future releases.

For this a deprecated decorator has been added in util/misc.
@fernandezc
minor corrections.
4c15af5
@fernandezc
Copy link
Contributor Author

Hello,
Do you know why it takes so long to perform the travis checks for each PR I do on the master branch of the nmrglue repository, while it is immediate on my fork? I'd like to understand!
Thanks.

@kaustubhmote
Copy link
Collaborator

Nice catch! However, there are a ton of other places (in examples/doc) where things must be changed for this to be complete. So I'll not immediately merge this. I am not sure about the travis checks, but I'll try and see if this can be fixed.

@fernandezc
Copy link
Contributor Author

However, there are a ton of other places (in examples/doc) where things must be changed for this to be complete.

Yes you are right. I'd noticed this also. This is why I added the deprecated decorator. But as I said before, this is not very important.
Best regards.

@DimitriPapadopoulos DimitriPapadopoulos mentioned this pull request Jan 12, 2022
Merged
@DimitriPapadopoulos DimitriPapadopoulos mentioned this pull request Dec 6, 2022
Merged
@DimitriPapadopoulos DimitriPapadopoulos mentioned this pull request Sep 29, 2023
Merged
@jjhelmus
Copy link
Owner

This and the other locations of seperate were replaced in #203. I think leaving the misspelled function in for backwards compatibility is fine rather than going through a deprecation cycle.

@jjhelmus jjhelmus closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fernandezc @kaustubhmote @jjhelmus