Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos found by codespell #165

Merged
merged 2 commits into from
Jan 14, 2022
Merged

Typos found by codespell #165

merged 2 commits into from
Jan 14, 2022

Conversation

DimitriPapadopoulos
Copy link
Contributor

Add a codespell section in setup.cfg in the process.

Copy link
Collaborator

@kaustubhmote kaustubhmote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! That's a lot of typos! Thanks for doing this.
I only suggest that the links to the files named seperate.py be kept as is (with the typo) to avoid breaking the link. Along with #139, this all should be fixed carefully so as to not break any of the code (or the links).

@@ -5,6 +5,6 @@ The data used in this example is available for

Listing S6

[:download:`seperate.py <../../../examples/jbnmr_examples/s6_seperate_inner_phase/seperate.py>`]
[:download:`separate.py <../../../examples/jbnmr_examples/s6_seperate_inner_phase/separate.py>`]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will break the link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something had gone wrong while pushing my final changes. Don't know what, but it's fixed now.

doc/source/jbnmr_examples/s6_seperate_inner_phase.rst Outdated Show resolved Hide resolved
doc/source/jbnmr_examples/s5_seperate_interleaved.rst Outdated Show resolved Hide resolved
@@ -5,6 +5,6 @@ The data used in this example is available for

Listing S5

[:download:`seperate.py <../../../examples/jbnmr_examples/s5_seperate_interleaved/seperate.py>`]
[:download:`separate.py <../../../examples/jbnmr_examples/s5_seperate_interleaved/separate.py>`]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will break the link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@@ -5,6 +5,6 @@ The data used in this example is available for

Listing S5

[:download:`separate.py <../../../examples/jbnmr_examples/s5_seperate_interleaved/separate.py>`]
[:download:`seperate.py <../../../examples/jbnmr_examples/s5_seperate_interleaved/seperate.py>`]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will break the link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.


.. literalinclude:: ../../../examples/jbnmr_examples/s5_seperate_interleaved/separate.py
.. literalinclude:: ../../../examples/jbnmr_examples/s5_seperate_interleaved/seperate.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will break the link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@@ -5,6 +5,6 @@ The data used in this example is available for

Listing S6

[:download:`separate.py <../../../examples/jbnmr_examples/s6_seperate_inner_phase/separate.py>`]
[:download:`seperate.py <../../../examples/jbnmr_examples/s6_seperate_inner_phase/seperate.py>`]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will break the link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.


.. literalinclude:: ../../../examples/jbnmr_examples/s6_seperate_inner_phase/separate.py
.. literalinclude:: ../../../examples/jbnmr_examples/s6_seperate_inner_phase/seperate.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will break the link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@DimitriPapadopoulos
Copy link
Contributor Author

I thought I hadn't changed the file names. I may have forgotten to push my latest changes.

I agree, these file names might be changed, but in a distinct and dedicated PR (#139).

Add a codespell section in setup.cfg in the process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants