Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move deleteBooking from AmenityController to BookingController #220

Closed
mslowiak opened this issue Feb 16, 2021 · 3 comments · Fixed by #261
Closed

Move deleteBooking from AmenityController to BookingController #220

mslowiak opened this issue Feb 16, 2021 · 3 comments · Fixed by #261
Assignees
@hsergiu
Labels
good first issue Good for newcomers up-for-grabs up-for-grabs

Comments

@mslowiak
Copy link
Collaborator

It is more like a cleanup task.

Things to be done:

  • move logic from AmenityController to BookingController (new class)
  • rewrite API specs to api.yaml file
  • change resource URL from /bookings/{bookingId} to /amenities/{amenityId}/bookings/{bookingId}
@mslowiak mslowiak added help wanted Extra attention is needed good first issue Good for newcomers up-for-grabs up-for-grabs and removed help wanted Extra attention is needed labels Feb 16, 2021
This was referenced Feb 18, 2021
Open
Closed
@hsergiu
Copy link
Contributor

hsergiu commented Mar 13, 2021

Can I take this one?

@mslowiak
Copy link
Collaborator Author

Sure, go ahead @hsergiu !

hsergiu added a commit to hsergiu/MyHome that referenced this issue Mar 14, 2021
@hsergiu
Issue jmprathab#220:Move deleteBooking from AmenityController to Book…
ca0ca4b 
…ingController
hsergiu added a commit to hsergiu/MyHome that referenced this issue Mar 14, 2021
@hsergiu
Issue jmprathab#220: cleanup
e1beacb
@hsergiu hsergiu mentioned this issue Mar 14, 2021
Merged
6 tasks
hsergiu added a commit to hsergiu/MyHome that referenced this issue Mar 16, 2021
@hsergiu
Issue jmprathab#220:updated deleteBooking
d80b572
hsergiu added a commit to hsergiu/MyHome that referenced this issue Mar 16, 2021
@hsergiu
Issue jmprathab#220:improve coverage
d60507e
@prabinamatya
Copy link

prabinamatya commented Aug 20, 2021 •
edited
Loading

@mslowiak Is this still open? Can I take it?

mslowiak added a commit that referenced this issue Sep 3, 2022
@mslowiak
Merge pull request #261 from hsergiu/feature/issue-220--move-deleteBo…
76d012f 
…oking-to-BookingController

Issue #220: Move deleteBooking from AmenityController to BookingController
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsergiu hsergiu

Labels
good first issue Good for newcomers up-for-grabs up-for-grabs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #220: Move deleteBooking from AmenityController to BookingController hsergiu/MyHome
3 participants
@prabinamatya @mslowiak @hsergiu