Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #220: Move deleteBooking from AmenityController to BookingController #261

Conversation

hsergiu
Copy link
Contributor

@hsergiu hsergiu commented Mar 14, 2021

๐Ÿš€ Description

Moved deleteBooking to BookingController.
Moved the used method from AmenityService to BookingService.
Added resource to api.yaml.
Fixed tests.

๐Ÿ“„ Motivation and Context

Closes: #220

๐Ÿ“ฆ Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

โœ… Checklist

  • My code follows the code style of this project(Do your best to follow code styles. If none apply just skip this).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@hsergiu hsergiu changed the title Feature/issue 220 move delete booking to booking controller Issue #220: move delete booking to booking controller Mar 14, 2021
@hsergiu hsergiu changed the title Issue #220: move delete booking to booking controller Issue #220: Move deleteBooking from AmenityController to BookingController Mar 14, 2021
@codecov
Copy link

codecov bot commented Mar 14, 2021

Codecov Report

Merging #261 (d60507e) into master (c123298) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #261      +/-   ##
============================================
+ Coverage     71.88%   72.06%   +0.17%     
- Complexity      223      225       +2     
============================================
  Files            36       38       +2     
  Lines           939      945       +6     
  Branches         42       43       +1     
============================================
+ Hits            675      681       +6     
  Misses          256      256              
  Partials          8        8              
Impacted Files Coverage ฮ” Complexity ฮ”
...java/com/myhome/controllers/AmenityController.java 82.60% <รธ> (-2.58%) 8.00 <0.00> (-2.00)
...me/services/springdatajpa/AmenitySDJpaService.java 97.36% <รธ> (-0.31%) 9.00 <0.00> (-2.00)
.../services/springdatajpa/CommunitySDJpaService.java 94.11% <รธ> (รธ) 33.00 <0.00> (รธ)
...java/com/myhome/controllers/BookingController.java 100.00% <100.00%> (รธ) 3.00 <3.00> (?)
...me/services/springdatajpa/BookingSDJpaService.java 100.00% <100.00%> (รธ) 3.00 <3.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
ฮ” = absolute <relative> (impact), รธ = not affected, ? = missing data
Powered by Codecov. Last update c123298...d60507e. Read the comment docs.

@mslowiak
Copy link
Collaborator

@hsergiu did you set a draft on purpose or it is ready for review? :)

@hsergiu
Copy link
Contributor Author

hsergiu commented Mar 15, 2021

The draft is on purpose. Need to change some things.

@hsergiu hsergiu marked this pull request as ready for review March 16, 2021 10:38
@mslowiak mslowiak merged commit 76d012f into jmprathab:master Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move deleteBooking from AmenityController to BookingController
3 participants