Skip to content

Commit

Permalink
fix(text): Fix UI test failures
Browse files Browse the repository at this point in the history
A new UI test added in a recent CL involved manually setting the
currentTime value of a videoElement in tests.
For some reason that wasn't working on Safari, so this changes that
UI test to use a fake video instead of a real one.

Closes shaka-project#3689

Change-Id: I412f677f6cda49bbfc850a9102edfe3b75bca302
  • Loading branch information
theodab committed Oct 8, 2021
1 parent a4e348d commit 7da2cd5
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions test/text/ui_text_displayer_unit.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
* SPDX-License-Identifier: Apache-2.0
*/

goog.require('shaka.test.UiUtils');
goog.require('shaka.test.Util');
goog.require('shaka.text.Cue');
goog.require('shaka.text.UITextDisplayer');
Expand Down Expand Up @@ -51,8 +50,7 @@ describe('UITextDisplayer', () => {
/** @type {!HTMLElement} */ (document.createElement('div'));
videoContainer.style.height = `${videoContainerHeight}px`;
document.body.appendChild(videoContainer);
video = shaka.test.UiUtils.createVideoElement();
videoContainer.appendChild(video);
video = new shaka.test.FakeVideo();
});

beforeEach(() => {
Expand Down

0 comments on commit 7da2cd5

Please sign in to comment.