Upgrade modifier capabilities to 3.22 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am using this addon as a dependency of I have seen other modifiers use compatibility helpers to continue to support old versions while upgrading capabilities only for those Ember versions that support them. See e.g. emberjs/ember-render-modifiers#33 (comment) @josemarluedke would you consider doing that? Or at least accept a PR? :) |
|
Hi @simonihmig! I think that solution is great. I would love to get a PR for that if you have cycles. |
simonihmig
added a commit
to simonihmig/ember-focus-trap
that referenced
this pull request
May 26, 2021
As discussed in josemarluedke#33 (comment), this introduces a conditional to support Ember 3.16+ while still using the latest modifier capabilities when possible. `@embroider/macros` was chosen for this instead of the usual `ember-compatibility-helpers`, as that seems to more future-proof solution to me, especially allowing an easier transition to an eventual native "v2" addon.
simonihmig
added a commit
to simonihmig/ember-focus-trap
that referenced
this pull request
May 27, 2021
As discussed in josemarluedke#33 (comment), this introduces a conditional to support Ember 3.16+ while still using the latest modifier capabilities when possible. `@embroider/macros` was chosen for this instead of the usual `ember-compatibility-helpers`, as that seems to more future-proof solution to me, especially allowing an easier transition to an eventual native "v2" addon.
simonihmig
added a commit
to simonihmig/ember-focus-trap
that referenced
this pull request
May 27, 2021
As discussed in josemarluedke#33 (comment), this introduces a conditional to support Ember 3.16+ while still using the latest modifier capabilities when possible. `@embroider/macros` was chosen for this instead of the usual `ember-compatibility-helpers`, as that seems to more future-proof solution to me, especially allowing an easier transition to an eventual native "v2" addon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addon now requires Ember v3.22 due to the new capabilities.