Add back support for Ember 3.16 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@josemarluedke this is what we discussed yesterday in #33. Hope it now works across all previously supported Ember versions, but we can only be sure once you enable CI to run (being a new "untrusted" contributor here) 😉 |
|
@simonihmig changes are looking good! I think we need to add to the dependencies and import |
As discussed in josemarluedke#33 (comment), this introduces a conditional to support Ember 3.16+ while still using the latest modifier capabilities when possible. `@embroider/macros` was chosen for this instead of the usual `ember-compatibility-helpers`, as that seems to more future-proof solution to me, especially allowing an easier transition to an eventual native "v2" addon.
|
Hm, idk how in heaven I managed to mess this up. I did have everything in place and tests were passing locally. Probably while working on the other PR I somehow lost some changes before committing. All green now! 😆 |
josemarluedke
approved these changes
May 27, 2021
|
Published in v0.7.0. Thank you for working on this @simonihmig! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #33 (comment), this introduces a conditional to support Ember 3.16+ while still using the latest modifier capabilities when possible.
@embroider/macroswas chosen for this instead of the usualember-compatibility-helpers, as that seems to be the more future-proof solution to me, especially allowing an easier transition to an eventual native "v2" addon.